Port boolean-crosses from turf (#12)#79
Open
trasch wants to merge 2 commits into
Open
Conversation
Implements booleanCrosses per the OpenGIS Simple Features spec, ported from turf-boolean-crosses. Supports MultiPoint/LineString, MultiPoint/Polygon, LineString/LineString, and LineString/Polygon comparisons. Also handles Feature and FeatureCollection inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ported
turf-boolean-crossesfrom Turf.js to Swift per OpenGIS Simple Features spec.Returns
trueif the intersection of two geometries results in a geometry whose dimension is one less than the maximum dimension of the two source geometries, and the intersection set is interior to both.Supported combinations
MultiPointLineStringMultiPointPolygon/MultiPolygonLineStringLineStringLineStringPolygon/MultiPolygonFeatureFeatureCollectionfalseChanges
Sources/GISTools/Algorithms/BooleanCrosses.swift// TODOwith full implementationGeoJson.crosses(_:) -> Bool— main entry pointFeatureunwrapping andFeatureCollectionflatteningisPointOnLineSegmentutilityCoordinate3D.isCoincident(to:)helper for endpoint tolerance checkTests/GISToolsTests/Algorithms/BooleanCrossesTests.swift— 16 testsLineString × LineStringcrossing, non-crossing (parallel), endpoint-touchingMultiPoint × LineString/MultiPoint × Polygoncrossing + non-crossingLineString × Polygon/LineString × MultiPolygoncrossing + non-crossingFeatureunwrapping,FeatureCollectionsupportfalseTest results
All 282 tests pass across 60 suites (was 266, +16 new).
Closes #12