fix(environment): give DEV an identity color - #2747
Open
HandSonic wants to merge 1 commit into
Open
Conversation
listAll shipped DEV without a color while TEST/RELEASE define GREEN/RED; the client types Environment.color as non-null and lowercases it for badge styling, so any new consumer would NPE on DEV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — contract gap found by reviewing 14729e0 (identity colors); described below.
Summary
SysEnvironmentServiceImpl defines colors for TEST (GREEN) and RELEASE (RED) but DEV shipped with none: /api/common/environment/list_all returns color: null for DEV while the client types Environment.color as non-null and uses it directly for badge styling (current consumers happen to guard; any new consumer calling .color.toLocaleLowerCase() throws). DEV now carries BLUE, and a test pins that every environment defines a non-blank color.
Affected surfaces
Verification
Risk and compatibility
Reviewer map
Contributor declaration
AI assistance: substantial — fix and tests drafted with AI assistance, verified locally.