fix(desktop): restore maximized window dragged by the caption - #2746
Open
HandSonic wants to merge 1 commit into
Open
fix(desktop): restore maximized window dragged by the caption#2746HandSonic wants to merge 1 commit into
HandSonic wants to merge 1 commit into
Conversation
Dragging the custom Windows title bar while the window is maximized kept calling setLocation against the maximized bounds, so the window stayed pinned instead of following the pointer until the user restored it by double-clicking. The drag handler now clears MAXIMIZED_BOTH on the first drag event and re-anchors the window under the pointer at the same relative position, matching native Windows behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — defect found by reviewing the #2711 desktop chrome series; described below.
Summary
Dragging the custom Windows title bar while the window is maximized kept calling setLocation against the maximized bounds: the window stayed pinned instead of following the pointer until the user restored it by double-clicking. The drag handler now clears MAXIMIZED_BOTH on the first drag event and re-anchors the window under the pointer at the same relative position (new pure restoredDragOrigin), matching native Windows behavior.
Affected surfaces
Verification
Risk and compatibility
Reviewer map
Contributor declaration
AI assistance: substantial — fix and tests drafted with AI assistance, verified locally.