fix(workspace): remember left panel width across collapse - #2745
Open
HandSonic wants to merge 1 commit into
Open
fix(workspace): remember left panel width across collapse#2745HandSonic wants to merge 1 commit into
HandSonic wants to merge 1 commit into
Conversation
togglePanelLeft reset the live width to the 260px default on expand and getPersistableWorkspaceLayout stored 0 while collapsed, so a user's custom sidebar width was permanently lost after collapsing (or a reload while collapsed). The layout now tracks lastPanelLeftWidth alongside the live width: collapsing remembers the current width, expanding restores it, and persistence/hydration carry the remembered value (legacy layouts without it fall back to the previous behavior).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — regression found by reviewing 2771426 + its persistence helper; described below.
Summary
togglePanelLeft reset the live width to the 260px default on expand, and getPersistableWorkspaceLayout stored 0 while collapsed — a user's custom sidebar width was permanently lost after collapsing (or reloading while collapsed). The layout now tracks lastPanelLeftWidth alongside the live width via a pure nextPanelLeftLayout helper: collapsing remembers the current width, expanding restores it, setPanelLeftWidth keeps it fresh, and persistence/hydration carry the remembered value (legacy layouts without it fall back to previous behavior).
Affected surfaces
Verification
Risk and compatibility
Reviewer map
Contributor declaration
AI assistance: substantial — fix and tests drafted with AI assistance, verified locally.