fix(titlebar): keep window controls under modal masks and localize their tooltips - #2744
Open
HandSonic wants to merge 2 commits into
Open
fix(titlebar): keep window controls under modal masks and localize their tooltips#2744HandSonic wants to merge 2 commits into
HandSonic wants to merge 2 commits into
Conversation
The app title bar has carried z-index: 10001 since the initial 4.0.0 code drop (d404467), where it only needed to outrank the host splash overlay convention (OpenScreenAnimation z-index 10000, removed early in init) while the bar hosted no interactive chrome. Since 2771426 the bar hosts real window controls (minimize/maximize/close via jcefApi), and antd modal masks/wraps plus the custom DraggableResizableModal overlay render at z-index 1000, so on the Windows desktop build the window close button floated above every confirmation dialog and could close the app while an unsaved-changes guard modal was open. Lower the bar to z-index 999: the highest value still below the modal layer (1000), and above every in-flow workspace stacking context (max z-index inside content is 100). Dropdown menus opened from the bar (CommunityAppMenu) are unaffected because they portal to document.body and global.ts already forces .ant-dropdown to z-index 11000. The -webkit-app-region drag area is not influenced by z-index.
The Windows window control buttons (minimize/maximize/restore/close)
hardcoded English aria-label/title strings while the rest of the title
bar (CommunityAppMenu) already uses i18n('common.menu.*').
Add common.window.{minimize,maximize,restore,close} to every maintained
locale (en-US, zh-CN, ja-JP, ko-KR, es-ES) and use them for both the
aria-label and title of the three window control buttons. Refresh the
English source hashes in scripts/i18n-source-hashes.json via
'node ./scripts/validate-i18n.cjs --write-source-hashes' (same method as
dd27eb2) and add a key-parity test (yarn test:i18n-window-controls)
asserting the four keys exist non-empty in every locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — two defects found by reviewing the #2711 desktop chrome series; described below.
Summary
Affected surfaces
Verification
Risk and compatibility
Reviewer map
Contributor declaration
AI assistance: substantial — fixes and tests drafted with AI assistance, verified locally and cross-checked by a second pass.