fix(tree): stop reporting failed post-save refreshes as save failures and re-read hidden nodes on refresh - #2743
Open
HandSonic wants to merge 2 commits into
Open
Conversation
After a successful datasource save, refreshDataSourceAfterMutation awaited hydrateDataSourceAfterMutation with throwOnError, so a transiently failed refresh rejected into ConnectionEdit's save-error toast and the user saw a failed save (and lost the new-datasource selection) even though the save persisted. The store action now runs through runMutationRefreshQuietly, which logs the refresh failure instead of rejecting; hydrate's propagating contract (and its tests) stay unchanged.
initHiddenTreeNodeIds early-returned once loaded, so changes persisted by another window never became visible even after clicking refresh. A refresh now forces a coordinator reset and re-read of the persisted hidden-node config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — two regressions found by reviewing 5372213 (race-safe tree refresh); described below.
Summary
Affected surfaces
Verification
Risk and compatibility
Reviewer map
Contributor declaration
AI assistance: substantial — fixes and tests drafted with AI assistance, verified locally.