Skip to content

fix(history): add scoped operation log filtering - #2696

Open
HandSonic wants to merge 6 commits into
OtterMind:mainfrom
HandSonic:fix/operation-log-filtering-2241
Open

fix(history): add scoped operation log filtering#2696
HandSonic wants to merge 6 commits into
OtterMind:mainfrom
HandSonic:fix/operation-log-filtering-2241

Conversation

@HandSonic

Copy link
Copy Markdown
Contributor

Filters operation history by scope and search before pagination; adds filters and debounced search to Output and SQL Audit views; and prevents stale responses from overwriting current state. Validated by fork frontend/backend CI and Java/JavaScript CodeQL. Fixes #2241.

@HandSonic
HandSonic force-pushed the fix/operation-log-filtering-2241 branch from dd1fe4c to adf283c Compare August 19, 2026 20:09

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: the new UI sends , but the backend drops it before storage. has the field, while does not, so MapStruct cannot carry it through; then filters only datasource/database/schema/search text. As a result, the Output request for and SQL Audit request for still query the same mixed stream.\n\nPlease add the operation type to the domain request, propagate it through the converter, filter it before pagination in local storage, and cover the separation with a backend test. The existing scope/search filtering and stale-response protection otherwise look sound.

@openai0229
openai0229 dismissed their stale review August 20, 2026 03:45

Superseded by a corrected review because shell quoting corrupted the submitted text.

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: the new UI sends operationType, but the backend drops it before storage. OperationLogQueryRequest has the field, while OpsOperationLogPageQueryRequest does not, so MapStruct cannot carry it through; LocalWorkspaceStorage.operationLogList then filters only datasource/database/schema/search text. As a result, the Output request for SQL_EXECUTE and SQL Audit request for SQL_AUDIT still query the same mixed stream.

Please add the operation type to the domain request, propagate it through the converter, filter it before pagination in local storage, and cover the separation with a backend test. The existing scope/search filtering and stale-response protection otherwise look sound.

@HandSonic
HandSonic requested a review from a team as a code owner August 22, 2026 14:49
@HandSonic HandSonic closed this Aug 22, 2026
@HandSonic HandSonic reopened this Aug 22, 2026
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Aug 22, 2026
@openai0229 openai0229 moved this from Done to In Review in Chat2DB Community Aug 22, 2026
# Conflicts:
#	chat2db-community-client/package.json
#	chat2db-community-client/src/hooks/useSelectDatabase.ts
#	chat2db-community-client/src/pages/main/organization/components/SQLAudit/index.tsx
#	chat2db-community-client/src/pages/main/organization/components/SQLAudit/style.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Add filters and search to SQL execution history

2 participants