Skip to content

fix(frontend): ignore stale account grants - #2691

Open
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/account-grants-latest-request
Open

fix(frontend): ignore stale account grants#2691
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/account-grants-latest-request

Conversation

@HandSonic

Copy link
Copy Markdown
Contributor

Summary

  • Ignore stale database-account grants requests when switching accounts.
  • Keep the loading state owned by the latest request and invalidate callbacks on unmount.

Validation

  • Account grants race regression scenarios
  • ESLint and Stylelint
  • Community production build

@HandSonic
HandSonic requested a review from openai0229 as a code owner August 12, 2026 02:14
@openai0229 openai0229 moved this to In Review in Chat2DB Community Aug 12, 2026
@HandSonic
HandSonic force-pushed the fix/account-grants-latest-request branch from 02ec4bd to 5046a13 Compare August 12, 2026 16:48
@HandSonic
HandSonic force-pushed the fix/account-grants-latest-request branch from 5046a13 to 5cb00fb Compare August 19, 2026 19:45
openai0229
openai0229 previously approved these changes Aug 20, 2026

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request generation and unmount invalidation prevent stale grants and loading state from overwriting the latest account selection. Error handling remains scoped to the current request. Approved.

@openai0229
openai0229 dismissed their stale review August 20, 2026 03:45

Superseded by a corrected review because shell quoting corrupted the submitted text.

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request generation and unmount invalidation prevent stale grants and loading state from overwriting the latest account selection. Error handling remains scoped to the current request. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants