Repository navigation
Fix the last queued job being skipped after pre-parsing - #44
Open
gabriel-andreescu wants to merge 1 commit into
Open
gabriel-andreescu wants to merge 1 commit into
gabriel-andreescu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling a single Fallout 4 script without
--parallel-compilecan return success without writing a PEX. I reproduced this with a script containing onlyScriptname QueueCheck.This became reproducible after c9e91d2 added input pre-parsing for namespace resolution. The same input produces a PEX on its parent commit.
Pre-parsing can complete a read job before the queue is drained.
tryDeque()advances past that job but returns false because it has already run. With only the write job left,queuedItemCountis zero and the worker shuts down before writing the PEX.Return the dequeued job whenever the queue advances.
tryRun()already skips completed jobs, so draining continues to the final job.The single-script case now produces its PEX. Single-file and directory compilation also passed for Skyrim and Fallout 4, both sequentially and in parallel.