This repository was archived by the owner on Apr 30, 2026. It is now read-only.
BIG UPDATE. - #51
Open
Snewmy wants to merge 7 commits into
Open
Conversation
Minor Changes: - Command system no longer uses plugin.yml, and now has values from the config.yml to easily change the command name and aliases, by extending BukkitCommand and using a lil reflection. (Deleted tab completer classes, and changed PlayerMessages into just a utility class instead of an abstract class. - Inventory/GUI handling system changed from the ol' checking inventory name, to using InventoryHolder. - Converted quest save/load system to use quest id's instead of index, due to the fact that any quests that fail to load will ruin the index system, making player's quests reset everytime they login and log-out. Quest IDs being the number in each quest file. - Added paperweight & runPaper gradle plugins for easy testing. - Added lombok for easy getters and setters. A lot of other classes can be converted to using lombok but I mostly left the others alone and just used it on any class that I had to add. ** MAJOR CHANGES ** Quests can now run multiple systems at once, so you can have one on one quest mode and temporality mode, and one on the other. By default I named these for having "weekly" quests running at the same time as daily quests, however all of the names and everything are easily changed. - All basic data that was previously stored is now stored inside an object called "QuestSystem", which is simply loaded onEnable(). From there, every method that would previously load quests, or get the mode, quests, literally anything, now will have a QuestSystem object in the parameter, to get the respective systems data. How this is done is simply by doing a forEach() lambda. - By Default, the second system is turned off (can be adjusted in config), and the plugin will function completely normally.
…ogress with other players.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor Changes:
Command system no longer uses plugin.yml, and now has values from the config.yml to easily change the command name and aliases, by extending BukkitCommand and using a lil reflection. (Deleted tab completer classes, and changed PlayerMessages into just a utility class instead of an abstract class.
Inventory/GUI handling system changed from the ol' checking inventory name, to using InventoryHolder.
Converted quest save/load system to use quest id's instead of index, due to the fact that any quests that fail to load will ruin the index system, making player's quests reset everytime they login and log-out. Quest IDs being the number in each quest file.
Added paperweight & runPaper gradle plugins for easy testing.
Added lombok for easy getters and setters. A lot of other classes can be converted to using lombok but I mostly left the others alone and just used it on any class that I had to add.
** MAJOR CHANGES **
Quests can now run multiple systems at once, so you can have one on one quest mode and temporality mode, and one on the other. By default I named these for having "weekly" quests running at the same time as daily quests, however all of the names and everything are easily changed.
All basic data that was previously stored is now stored inside an object called "QuestSystem", which is simply loaded onEnable(). From there, every method that would previously load quests, or get the mode, quests, literally anything, now will have a QuestSystem object in the parameter, to get the respective systems data. How this is done is simply by doing a forEach() lambda.
By Default, the second system is turned off (can be adjusted in config), and the plugin will function completely normally.