Repository navigation
feat(metadata): define canonical MarketMetadataV1 schema and JCS+NFC verification (#144) - #190
Open
ryder777777 wants to merge 1 commit into
Conversation
ryder777777
force-pushed
the
feat/issue-144-canonical-market-metadata
branch
from
October 21, 2026 12:38
399c42b to
f12af04
Compare
ryder777777
force-pushed
the
feat/issue-144-canonical-market-metadata
branch
from
October 25, 2026 16:35
f12af04 to
34f4289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds the v1 market metadata schema (
oracledesk.market-metadata/1) along with RFC 8785 JCS + Unicode NFC canonicalization in both TypeScript (agents/core/metadata.ts) and Python (model/market_metadata.py).docs/market-metadata.md&docs/market-metadata-vectors.json: schema rules, field limits, and shared golden vectors (combining characters, astral emoji UTF-16 key ordering vs BMPU+FB00, control char escaping, nested spec).agents/core/metadata.ts&model/market_metadata.py:validateMetadata,canonicalMetadataBytes,metadataHash,verifyMetadata(hashes raw received bytes before parsing and rejects non-canonical inputs),checkAgainstMarket, andLocalMetadataStore(ipfs://<cidv1>).agents/bin/market-maker.ts,scripts/seed-market.sh,scripts/verify-market.sh,docs/frontend-integration.md: wire canonical metadata creation and verification into market creation flows.Tested with
python3 model/market_metadata.pyandcd agents && npm test && npm run build.Closes #144
Checklist
cargo fmt --check,cargo clippy --all-targets -- -D warnings, andcargo testpassHow this was tested
Verified unit test cases covering nominal thresholds, boundary conditions, and deterministic state transitions.