Separate sampling from the distribution scoring contract - #88
Draft
jonathanberthias wants to merge 2 commits into
Draft
jonathanberthias wants to merge 2 commits into
jonathanberthias wants to merge 2 commits into
Conversation
jonathanberthias
force-pushed
the
migration/sampleable-capability
branch
from
September 27, 2026 15:27
c0e25e5 to
a43ab0f
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
from
September 27, 2026 15:27
e295cf4 to
141a918
Compare
jonathanberthias
force-pushed
the
migration/sampleable-capability
branch
from
September 27, 2026 20:09
a43ab0f to
3fda28a
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
2 times, most recently
from
September 27, 2026 20:27
53554f1 to
5a7a426
Compare
jonathanberthias
force-pushed
the
migration/sampleable-capability
branch
2 times, most recently
from
October 2, 2026 21:05
ef29e8b to
5490832
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
from
October 2, 2026 21:05
9e3f684 to
22b2aa8
Compare
jonathanberthias
force-pushed
the
migration/sampleable-capability
branch
from
October 2, 2026 22:25
5490832 to
a4e6af2
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
from
October 2, 2026 22:25
22b2aa8 to
6a6b37c
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
from
October 3, 2026 11:02
6a6b37c to
4f6d924
Compare
jonathanberthias
force-pushed
the
migration/sampleable-capability
branch
from
October 3, 2026 11:03
a4e6af2 to
8def56e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new distribution base currently requires random sampling even though fitting, scoring, profiling, and information criteria only need pointwise
log_prob. That requirement would force future scoreable models to implement a sampler before they can use the shared graph.This PR makes
Distributionthe scoring contract and addsSampleableDistributionfor laws that supportrvs. Existing SciPy wrappers, extreme-value conveniences, truncation, and Bernoulli explicitly implement the sampling capability. A score-only distribution can now participate in fitting without a placeholder sampler.The continuous CDF and quantile operations remain a separate capability; this change does not add requirements for discrete or multivariate laws.