Add information criteria for explicit-state fits - #87
Draft
jonathanberthias wants to merge 3 commits into
Draft
jonathanberthias wants to merge 3 commits into
jonathanberthias wants to merge 3 commits into
Conversation
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
3 times, most recently
from
September 27, 2026 20:27
53554f1 to
5a7a426
Compare
jonathanberthias
force-pushed
the
migration/bernoulli
branch
from
September 27, 2026 20:27
04e3ff6 to
ad55c57
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
from
October 2, 2026 21:05
9e3f684 to
22b2aa8
Compare
jonathanberthias
force-pushed
the
migration/bernoulli
branch
from
October 2, 2026 22:25
1aa980d to
796ffab
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
from
October 2, 2026 22:25
22b2aa8 to
6a6b37c
Compare
jonathanberthias
force-pushed
the
migration/bernoulli
branch
from
October 3, 2026 11:02
796ffab to
ed06a0b
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-metrics
branch
from
October 3, 2026 11:03
6a6b37c to
4f6d924
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit-state fitting path has a common
log_probobjective and retains its fitting observations, but information criteria still live in the legacy metrics module, which reads mutable distribution parameters and cannot score aFitResult. The likelihood helper can also silently sum an extra model batch axis.This PR adds
aic(fit)andbic(fit)for explicit-state MLE results. Both evaluate the model at the result's state on its retained fitting dataset, count only free parameter coordinates, and require a successful fit and finite evaluated likelihood. BIC counts observations along the first data axis, with scalar data counting as one observation. Dataset likelihood aggregation requires one pointwise log score per observation.AIC and BIC are evaluated after MLE fitting. For a fixed model their penalties are constant in the parameter values, so minimizing them would give the same fitted state as minimizing negative log likelihood. Predictive scores that can change the fit are handled in a separate slice.