Add explicit-state profile likelihood - #82
Draft
jonathanberthias wants to merge 4 commits into
Draft
jonathanberthias wants to merge 4 commits into
jonathanberthias wants to merge 4 commits into
Conversation
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
September 26, 2026 14:25
6b2278f to
f2c99b3
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
September 26, 2026 19:15
f2c99b3 to
865ad0d
Compare
jonathanberthias
added this pull request to stack #84
September 26, 2026 19:15
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
2 times, most recently
from
September 26, 2026 19:36
42708cb to
f14acb9
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
2 times, most recently
from
September 26, 2026 19:52
3df77ca to
698a81a
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
September 27, 2026 11:43
698a81a to
d17dc33
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
2 times, most recently
from
September 27, 2026 12:12
f6fefc3 to
67b49e8
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
September 27, 2026 12:17
67b49e8 to
ee2664d
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
September 27, 2026 13:46
ee2664d to
3e0f5b9
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
September 27, 2026 13:51
3e0f5b9 to
6d69535
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
September 27, 2026 20:27
6d69535 to
4e1e242
Compare
jonathanberthias
force-pushed
the
migration/explicit-state-profiler
branch
from
October 2, 2026 22:25
4e1e242 to
fd2630a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public profiler refits by creating distributions with replaced parameter values. It cannot directly use a stable structural model with an explicit fitted state.
FitResultalso omits fitting observations, which would force a new profiler to accept a second dataset and risk profiling different data.This PR retains an independent, read-only observation snapshot on
FitResultand addsProfiler(fit, confidence=...). It fixes a scalarParameterat each physical candidate value and refits nuisance parameters on the shared snapshot. Nearby successful profiles supply starting states. Interval searches stop expanding once they have a valid likelihood-cutoff bracket, then refine the confidence limits with Brent's method.The legacy public profiler remains available. Vector-parameter profiles and custom score functions need separate contracts. A general search for feasible nuisance starts is outside this slice; when available starts cannot produce a bracket, the profiler reports that failure without asserting a support boundary.