Skip to content

Add explicit-state distribution fitting path - #77

Open
jonathanberthias wants to merge 9 commits into
masterfrom
migration/distribution-core
Open

jonathanberthias wants to merge 9 commits into
masterfrom
migration/distribution-core

Conversation

@jonathanberthias

@jonathanberthias jonathanberthias commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Current situation

The parameter graph and explicit State already exist, but the public distribution path still fits by rebuilding distributions with fitted values. Node also defines arithmetic that always creates a FunctionExpr; a distribution needs to be a graph node, but cannot validly use those numeric-expression operators.

Change

Add an opt-in continuous distribution node, state-aware likelihood evaluation, and fit_mle. A FitResult retains the model and holds fitted values in a separate state. Literal constructor values become structural constants, while supplied Parameter nodes keep their identity. Move arithmetic from Node to Expr, leaving the shared node base responsible for graph traversal.

Notes

The existing public distribution API remains in place. Distribution arithmetic can later define operations with distribution-specific results; this PR gives no meaning to Distribution + Distribution. The new path is a continuous starting point, not the eventual common contract for discrete or multivariate laws.

@jonathanberthias
jonathanberthias force-pushed the migration/distribution-core branch from 2ec729c to fae4bc1 Compare September 26, 2026 14:25
@jonathanberthias
jonathanberthias changed the base branch from master to chore/pin-ruff-hook September 26, 2026 14:26
@jonathanberthias
jonathanberthias force-pushed the migration/distribution-core branch from fae4bc1 to aa932f0 Compare September 26, 2026 19:15
@jonathanberthias
jonathanberthias added this pull request to stack #84 September 26, 2026 19:15
Base automatically changed from chore/pin-ruff-hook to master September 26, 2026 19:28
@jonathanberthias
jonathanberthias force-pushed the migration/distribution-core branch from aa932f0 to 31d4bb3 Compare September 26, 2026 19:28
@jonathanberthias
jonathanberthias force-pushed the migration/distribution-core branch from 31d4bb3 to b8f0e28 Compare September 26, 2026 19:36
@jonathanberthias
jonathanberthias force-pushed the migration/distribution-core branch from 3cb8f98 to 167602f Compare September 26, 2026 19:52
@jonathanberthias
jonathanberthias marked this pull request as ready for review September 27, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant