Repository navigation
fix: reapply the ROM DFU USART1 line fix (#155) - #157
Merged
Merged
Conversation
#155 was reverted because a bare-metal update still left a sensor off USB until it was power-cycled. That update started from an image without the fix: the firmware that is running does the jump into the ROM loader, so the fix only takes effect for updates away from a build that carries it. Every update away from a fixed build restarted on the bench (2026-10-15): plain DFU enter + leave 3/3, SDK updates fix->fix x2 and fix->1.8.1. Updates away from 1.8.3-rc.2 and older bare-metal images still need one power cycle; after that the unit is on a fixed build and restarts itself. This reverts commit 3843752 (the merge of #156), restoring the code of 902e094 unchanged. Signed-off-by: George Vigelette <george@openwater.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #155, reverted in #156. The fix takes effect when the running firmware enters the ROM loader, so only updates away from a build that carries it restart without a power cycle. Bench 2026-10-15: plain DFU enter+leave 3/3, SDK updates fix->fix x2 and fix->1.8.1 all restarted.