Repository navigation
fix(console): name the safety-limits START refusal (0x20) - #326
Merged
Merged
Conversation
Console firmware with CFW-10 (console-fw fix/safety-limits-validate) refuses OW_CTRL_START_TRIG with status bit 0x20 when a safety limit named in the stored config was not loaded and verified (out of range, not a settable register, failed write or read-back mismatch). It clears on the next config apply that succeeds. Add TRIG_INTERLOCK_LIMITS (0x20) and its reason, so start_trigger() and ScanWorkflow report "a safety limit in the console config was not applied (out of range or failed read-back)". Tests: tests/test_trigger_limits.py; software suite no new failures. Bench: config with EE_PULSE_WIDTH_UL 700 -> start_trigger() False, refusal 0x20 with the reason above; stored config restored -> True. Signed-off-by: George Vigelette <george@openwater.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console firmware with CFW-10 (console-fw fix/safety-limits-validate) refuses OW_CTRL_START_TRIG with status bit 0x20 when a safety limit named in the stored config was not loaded and verified (out of range, not a settable register, failed write or read-back mismatch). It clears on the next config apply that succeeds.
Add TRIG_INTERLOCK_LIMITS (0x20) and its reason, so start_trigger() and ScanWorkflow report "a safety limit in the console config was not applied (out of range or failed read-back)".
Tests: tests/test_trigger_limits.py; software suite no new failures. Bench: config with EE_PULSE_WIDTH_UL 700 -> start_trigger() False, refusal 0x20 with the reason above; stored config restored -> True.
Summary
Licensing layer
license-manifestchange process (and board approval for anything leaving the core). Link the approval.Checklist
git commit -sSPDX-License-Identifierfor their layerCODEOWNERSreview requestedNotes for reviewers