Skip to content

fix(console): name the safety-status-unknown START refusal (0x10) - #325

Merged
georgevigelette merged 1 commit into
nextfrom
fix/safety-unknown-reason
Oct 15, 2026
Merged

georgevigelette merged 1 commit into
nextfrom
fix/safety-unknown-reason

Conversation

@georgevigelette

Copy link
Copy Markdown
Contributor

Console firmware with CFW-04 (console-fw fix/safety-status-unknown) refuses OW_CTRL_START_TRIG with status bit 0x10 when the EE or OPT safety FPGA STATUS could not be read for three polls in a row, and stops a running trigger. It clears once both read again with no fault.

Add TRIG_INTERLOCK_SAFETY_UNKNOWN (0x10) and its reason, so start_trigger() and ScanWorkflow report "laser-safety FPGA status unreadable (EE/OPT not responding)" instead of "unknown status bits 0x10".

Tests: tests/test_trigger_limits.py; software suite no new failures.

Summary

Licensing layer

  • Apache-2.0 extension (3D Slicer, wellness/veterinary module, partner SDK, language binding)
  • AGPL-3.0 core (firmware, sensing/beamforming/reconstruction/signal-processing/calibration algorithms, hardware reference design)
  • Docs / data / tooling only
  • This PR moves a file between the AGPL core and the Apache layer — if checked, this is NOT an ordinary PR: it requires the license-manifest change process (and board approval for anything leaving the core). Link the approval.

Checklist

  • Commits are signed off (DCO): git commit -s
  • New files carry the correct SPDX-License-Identifier for their layer
  • Tests and docs updated
  • No incompatible third-party code introduced
  • CI is green and CODEOWNERS review requested

Notes for reviewers

Console firmware with CFW-04 (console-fw fix/safety-status-unknown) refuses
OW_CTRL_START_TRIG with status bit 0x10 when the EE or OPT safety FPGA STATUS
could not be read for three polls in a row, and stops a running trigger. It
clears once both read again with no fault.

Add TRIG_INTERLOCK_SAFETY_UNKNOWN (0x10) and its reason, so start_trigger()
and ScanWorkflow report "laser-safety FPGA status unreadable (EE/OPT not
responding)" instead of "unknown status bits 0x10".

Tests: tests/test_trigger_limits.py; software suite no new failures.

Signed-off-by: George Vigelette <george@openwater.cc>
@georgevigelette
georgevigelette merged commit a435bcb into next Oct 15, 2026
2 checks passed
@georgevigelette
georgevigelette deleted the fix/safety-unknown-reason branch October 15, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant