Skip to content

fix(console): name the default-config START refusal (0x08) - #324

Merged
georgevigelette merged 1 commit into
nextfrom
fix/cfg-defaulted-reason
Oct 15, 2026
Merged

georgevigelette merged 1 commit into
nextfrom
fix/cfg-defaulted-reason

Conversation

@georgevigelette

Copy link
Copy Markdown
Contributor

Console firmware with CFW-03 (console-fw fix/cfg-defaulted-interlock) refuses OW_CTRL_START_TRIG with status bit 0x08 while it runs on its built-in default config because no valid stored record was found (first boot, erased sector, corruption). The bit is cleared by writing a config.

Add TRIG_INTERLOCK_CONFIG (0x08) and its reason, so start_trigger() reports "console user config invalid or missing; running on defaults until a config is written" instead of "unknown status bits 0x08", and ScanWorkflow passes that text on as the scan error.

Tests: tests/test_trigger_limits.py; software suite no new failures. Bench: config sector erased over SWD -> start_trigger() False, last_start_refusal 0x08 with the reason above; after write_config_json -> True.

Summary

Licensing layer

  • Apache-2.0 extension (3D Slicer, wellness/veterinary module, partner SDK, language binding)
  • AGPL-3.0 core (firmware, sensing/beamforming/reconstruction/signal-processing/calibration algorithms, hardware reference design)
  • Docs / data / tooling only
  • This PR moves a file between the AGPL core and the Apache layer — if checked, this is NOT an ordinary PR: it requires the license-manifest change process (and board approval for anything leaving the core). Link the approval.

Checklist

  • Commits are signed off (DCO): git commit -s
  • New files carry the correct SPDX-License-Identifier for their layer
  • Tests and docs updated
  • No incompatible third-party code introduced
  • CI is green and CODEOWNERS review requested

Notes for reviewers

Console firmware with CFW-03 (console-fw fix/cfg-defaulted-interlock)
refuses OW_CTRL_START_TRIG with status bit 0x08 while it runs on its built-in
default config because no valid stored record was found (first boot, erased
sector, corruption). The bit is cleared by writing a config.

Add TRIG_INTERLOCK_CONFIG (0x08) and its reason, so start_trigger() reports
"console user config invalid or missing; running on defaults until a config
is written" instead of "unknown status bits 0x08", and ScanWorkflow passes
that text on as the scan error.

Tests: tests/test_trigger_limits.py; software suite no new failures. Bench:
config sector erased over SWD -> start_trigger() False, last_start_refusal
0x08 with the reason above; after write_config_json -> True.

Signed-off-by: George Vigelette <george@openwater.cc>
@georgevigelette
georgevigelette merged commit af4bcf7 into next Oct 15, 2026
2 checks passed
@georgevigelette
georgevigelette deleted the fix/cfg-defaulted-reason branch October 15, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant