Skip to content

Remove read_adc_value / read_gpio_value (console commands 0x1E/0x1F retired) #302

Closed

Description

@boringethan

Part of OpenwaterHealth/openmotion-console-fw#12 (parent): the console firmware never implemented OW_CTRL_READ_ADC (0x1E) / OW_CTRL_READ_GPIO (0x1F), and both are being retired.

SDK side: remove the two constants from omotion/config.py, MotionConsole.read_adc_value() / read_gpio_value(), their xfail tests in tests/test_console.py, and their entries in docs/TestPlan.md.

Status and discussion live on the parent.

Activity

  1. boringethan commented on Oct 2, 2026

    @boringethan
    ContributorAuthor

    Merged to next in #303 (0d3c951). Status is tracked on the parent, OpenwaterHealth/openmotion-console-fw#12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions