feat: use "universal" UID#157
Conversation
JGodin-C2C
force-pushed
the
use_new_UID
branch
2 times, most recently
from
5e9aa81 to
4109e54
Compare
|
LGTM, can you add a section to the README and link the MIGRATION there? not that people still overlook it. |
this change is breaking Signed-off-by: Julien Godin <julien.godin@camptocamp.com>
|
FWIW, this pull request will break https://github.com/voxpupuli/container-r10k by default, unless you also change the default UID:GID there too. I agree with @bootc for keeping it 999:999 by default. That said, I do really like the MIGRATION.md and new section in the README.md; I've always wondered if the container upgrade required me to do anything or not. |
|
hey @zmcgrew ! the r10k container have an option for this. One could add some documentation in the About the "keep 999:999" i dont think that it is a good idea as it may collide with other services. Also,using high UID means that you do not need to add complexity over the "yeaaaah, sooo, we have two UIDs depending on which tag you actullay pull". The voluntary high UID/GID is choosen so the chance of collision remain low and makes sense in a kubernetes environment if that make sense. |
|
i'd like to favor this PR to solve the uid/gid discussion. the ids are high enough to not collide and it is documente how to get there. if we choose this, we also need to fix r10k. |
openvox container UID/GID is beeing changed to a more universal one. This PR reflect this change. container openvox pull request can be found here OpenVoxProject/container-openvoxserver#157 Signed-off-by: Julien Godin <julien.godin@camptocamp.com>
3 participants
this change is breaking
Short description
The usage of low UID may collid with existing UIDs in distros (for instance, 999 is UID for ping in alpine )