[abdulsaheel]

getBatteryPackInfo was the one battery-adjacent reply in this file with no status gate. getClock/getDataRange/getBatteryLevel(gen5)/getHello(gen5) all check cmd_status==1 on gen5 before trusting the body, this one didn't, so a gen5 failure/deferred reply with a stale-but-full-length body would still decode into a confident attached/mac/name/type.

fix mirrors the existing convention exactly: statusOk = !profile.isGen5 || status == 1, gen4 stays ungated (status byte unconfirmed there per the comment above getClock).

added two tests: gen5 success still decodes, gen5 cmd_status=0 gets dropped. existing gen4 success test untouched.

dart test: 617 passed, 4 skipped, 0 failed.

Summary by Sourcery

Gate gen5 battery pack information decoding on a successful command status while preserving existing gen4 behavior.

Bug Fixes:

• Prevent gen5 battery pack information from being decoded when the command reports a failed or deferred status, avoiding stale response data.

Tests:

• Add coverage for successful and rejected gen5 battery pack information responses based on command status.

[coderabbitai]

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 03a045bc-1a07-48e1-9d07-6911ed996556

📥 Commits

Reviewing files that changed from the base of the PR and between 1521962 and 538c482.

📒 Files selected for processing (2)

• lib/src/control.dart
• test/whoop_protocol_update_test.dart

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Sorry @abdulsaheel, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 6 days and 18 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's Guide

The PR aligns battery pack info parsing with the existing gen5 status-gating convention: successful gen5 replies are decoded, failed/deferred replies are discarded, and gen4 remains ungated. Tests cover both gen5 outcomes.

Flow diagram for battery pack info status gating

flowchart TD
    A[parseCommandResponse receives battery pack info] --> B{profile.isGen5}
    B -->|No| C[Decode BatteryPackInfoResponse]
    B -->|Yes| D{status == 1}
    D -->|Yes| C
    D -->|No| E[Discard battery pack info reply]

Loading

File-Level Changes

Change	Details	Files
Gate battery pack info decoding on the gen5 command status while preserving existing gen4 behavior.	Treat gen5 replies as decodable only when the echoed status is 1. Continue decoding gen4 replies without a status gate because its status semantics are unconfirmed. Leave decoded battery pack fields unchanged when the reply is accepted.	lib/src/control.dart
Add coverage for accepted and rejected gen5 battery pack replies.	Verify a gen5 success reply still decodes the battery identifier. Verify a gen5 failure reply with a full-length stale body produces no battery pack info. Retain existing gen4 success coverage.	test/whoop_protocol_update_test.dart

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.