Repository navigation
fix(ios): warn that deleting the app unpairs bands and sensors (refs #538) - #576
Conversation
… app (#538) AccessorySetupKit pairings are removed by iOS, bond included and for all apps, when OpenStrap is uninstalled. There is no hook to prevent it, so the sensor pairing screen, both forget dialogs and the reset dialog now say so on iOS only. New string translated for every shipped locale.
Reviewer's GuideThis PR adds a localized, iOS-only warning to pairing, unpairing, and reset flows, using a shared platform-aware text helper to explain that deleting the app removes AccessorySetupKit pairings for all apps. Widget coverage verifies the warning appears on iOS but not Android. Sequence diagram for the iOS uninstall pairing warningsequenceDiagram
participant User
participant Dialog as PairingOrResetUI
participant Helper as withIosUninstallWarning
participant Localizations
User->>Dialog: Open pairing, forget, or reset flow
Dialog->>Helper: withIosUninstallWarning(context, body)
alt iOS
Helper->>Localizations: Read iosUninstallUnpairsWarning
Localizations-->>Helper: Localized warning
Helper-->>Dialog: body plus uninstall warning
else Android or other platform
Helper-->>Dialog: body
end
Dialog-->>User: Display explanatory text
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughAdds a localized warning about iOS pairing loss when OpenStrap is uninstalled. The warning appears in sensor and band messages and in the reset confirmation on iOS. ChangesiOS Pairing Warning
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The warning is added to the intended iOS pairing and reset prompts, and its localization accessor is generated by the normal Flutter workflow. No actionable merge-blocking issue remains. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: warning iOS users that deleting the app unpairs bands and sensors. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitai review |
|
PR Reviewer Guide 🔍(Review updated until commit e7660ae)Here are some key observations to aid the review process:
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
PR Code Suggestions ✨Latest suggestions up to e7660ae Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit 54311be
|
|
Persistent review updated to latest commit e7660ae |
1 participant
User description
Refs #538. On iOS, AccessorySetupKit pairings are removed by the system when the app is deleted, so other apps (including the maker's own) lose the band or sensor too. The app cannot intercept that, so this adds a clear warning where it matters.
iosUninstallUnpairsWarningin all 7 locales.Moving rings off AccessorySetupKit (to avoid the unpair entirely) is a separate owner decision.
🤖 Generated with Claude Code
Summary by Sourcery
Warn iOS users before pairing, removing devices, or resetting data that deleting the app also unpairs its bands and sensors.
New Features:
Documentation:
Tests:
PR Type
Enhancement
Description
Adds a localized warning on iOS explaining that uninstalling the app unpairs paired bands and sensors from the system, affecting other apps.
Appends the warning to the sensor pairing screen, forget device dialogs, and the full reset dialog.
Includes widget tests to verify the warning is displayed exclusively on iOS.
Diagram Walkthrough
flowchart LR UI["Dialogs & Pairing Screen"] -- "Text rendering" --> Check{"Is iOS?"} Check -- "Yes" --> Append["Append Uninstall Warning"] Check -- "No" --> Original["Show Original Text"]File Walkthrough
4 files
Add helper to append iOS uninstall warningAdd iOS warning to forget device dialogsAdd iOS warning to sensor pairing explainerAdd iOS warning to full reset dialog1 files
Add tests for platform-specific warning visibility7 files
Add German translation for iOS warningAdd English string for iOS warningAdd Spanish translation for iOS warningAdd French translation for iOS warningAdd Hindi translation for iOS warningAdd Russian translation for iOS warningAdd Chinese translation for iOS warningSummary by CodeRabbit