[DO NOT MERGE] - Convert master branch to C (master-c)#147
Draft
livingkurt wants to merge 25 commits into
Draft
Conversation
livingkurt
changed the title
…obal flags handling and improve readability with consistent naming conventions.
…ces and enable wake on button press in sleep mode.
…related functions and initialization to streamline pattern configuration.
…ns, adjusting values for slots and total bytes.
…oved state management in the off menu handling.
… Pattern, Random, Storage, TimeControl, Timer, and CLI Makefile updates This commit introduces several new source files for the Helios project, implementing core functionalities such as button handling, color management, pattern definitions, and random number generation. Additionally, the Makefile for both CLI and Embedded versions has been updated to ensure proper compilation of the new C++ source files, enhancing the overall structure and maintainability of the project.
…ettings, remove main.c, and enhance version tagging process. The changes include switching from gcc to g++ for CFLAGS, consolidating source file handling, and renaming the release target for consistency.
…ne compiler settings.
…onfiguration files, while removing the exclusion for C source files. This enhances the project's build process by ensuring relevant files are tracked and managed correctly.
…om source file search, improving build accuracy and preventing unnecessary file inclusion.
…umentation and EEPROM dump output to reflect the change.
Unreal-Dan
reviewed
Oct 18, 2025
| // = 31 bytes left | ||
| // -> 9 slots = 9 * 28 = 252 | ||
| // = 3 bytes left | ||
| // 1 + 6 + 1 + 1 = 9 for the rest |
Collaborator
There was a problem hiding this comment.
wait why did this change, did this actually change or is this a hallucination lol?
Collaborator
Author
There was a problem hiding this comment.
Ah yeah I actually initially did this for the aeos-c branch and then had ai try to sort of copy over changes and it took it a little too literally haha, i git it put back now tho
Unreal-Dan
reviewed
Oct 18, 2025
| ifeq ($(OS),Windows_NT) | ||
| SRC = $(shell find ../Helios -type f -name \\*.cpp) \ | ||
| $(shell find . -type f -name \\*.cpp) | ||
| $(shell find . -type f -name \\*.cpp -not -path "./venv/*") |
Collaborator
There was a problem hiding this comment.
what is venv? interesting?
Collaborator
Author
There was a problem hiding this comment.
Yeah I know right? Funny that after I did a reinstall of macbook in order to run the python scripts in this pr I had to create a venv to run them
So in order to run them in through the make file I needed to include that path there
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…lti-line comments
… across the HeliosEmbedded project.
…ong press detection functions
…d adjust queue size for improved performance
#154) Port of master PR #152 cleanup changes to the master-c branch: - Add proper #ifndef/#define guard to ColorConstants.h (replacing #pragma once) - Rename Colortypes.h guard from COLOR_H to COLORTYPES_H to match filename - Remove helios_wakeup() from embedded ISR (not used on embedded) - Extract repeated time_get_current_time() calls into const local variable in button_update() for clarity - Remove unused Led.h include from TimeControl.cpp, reorder includes - Update TimeControl.h comments on time_get_current_time() and time_microseconds() for clarity Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.