Merge pull request #2611 from nxglabs/sync-to-public_repo-28355409725#2199
Merged
Conversation
Merge pull request #2610 from nxglabs/staging
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR syncs upstream/staging changes into the public repository, primarily updating Node dependencies/lockfiles and extending the OpenSign UI with additional template/document fields and localization strings (conditional logic + access code), alongside some widget-requiredness handling refactors and formatting cleanups.
Changes:
- Bumped backend server dependencies (multer / parse / parse-server) and updated associated lockfile resolutions.
- Added/propagated
SendInOrderStrictinto template/document form state and expanded locale strings for “conditional logic” and “access code” UX. - Refactored parts of widget required/optional evaluation and prefill widget update logic; applied assorted formatting changes.
Reviewed changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/OpenSignServer/package.json | Updates server dependency versions (multer / parse / parse-server). |
| apps/OpenSignServer/package-lock.json | Lockfile refresh to match updated server dependency graph. |
| apps/OpenSign/src/pages/TemplatePlaceholder.jsx | Adds SendInOrderStrict to template payload/state and minor formatting tweaks. |
| apps/OpenSign/src/pages/SignyourselfPdf.jsx | Formatting-only changes (trailing commas / parameter list). |
| apps/OpenSign/src/pages/PlaceHolderSign.jsx | Adds SendInOrderStrict mapping for document updates and minor formatting tweaks. |
| apps/OpenSign/src/constant/Utils.js | Refactors filter callbacks (no behavior change intended). |
| apps/OpenSign/src/components/pdf/WidgetsValueModal.jsx | Adjusts required/optional evaluation defaults, refactors widget traversal, and adds conditional-logic-related behavior (plus some cleanup needed). |
| apps/OpenSign/src/components/pdf/WidgetNameModal.jsx | Minor submission handling tweak (currently introduces redundant variable). |
| apps/OpenSign/src/components/pdf/SignerListPlace.jsx | Formatting changes (currently adds an unused React import). |
| apps/OpenSign/src/components/pdf/RecipientList.jsx | Formatting cleanup only. |
| apps/OpenSign/src/components/pdf/Placeholder.jsx | Formatting-only change (blank line). |
| apps/OpenSign/src/components/pdf/DropdownWidgetOption.jsx | Import list changed (currently includes an unused hook import). |
| apps/OpenSign/src/components/bulksend/components/PrefillWidgets.jsx | Changes prefill widget update to lookup by label rather than rendered index. |
| apps/OpenSign/public/locales/kr/translation.json | Adds conditional-logic and access-code strings (Korean). |
| apps/OpenSign/public/locales/it/translation.json | Adds conditional-logic and access-code strings (Italian). |
| apps/OpenSign/public/locales/hi/translation.json | Adds conditional-logic and access-code strings (Hindi). |
| apps/OpenSign/public/locales/fr/translation.json | Adds conditional-logic and access-code strings (French). |
| apps/OpenSign/public/locales/es/translation.json | Adds conditional-logic and access-code strings (Spanish). |
| apps/OpenSign/public/locales/en/translation.json | Adds conditional-logic and access-code strings (English). |
| apps/OpenSign/public/locales/de/translation.json | Adds conditional-logic and access-code strings (German). |
| apps/OpenSign/package-lock.json | Refreshes frontend lockfile with updated transitive/dev dependency versions. |
Files not reviewed (2)
- apps/OpenSign/package-lock.json: Generated file
- apps/OpenSignServer/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
2
| import { useState } from "react"; | ||
| import RecipientList from "./RecipientList"; |
| @@ -1,4 +1,4 @@ | |||
| import { useEffect, useState } from "react"; | |||
| import { useEffect, useMemo, useState } from "react"; | |||
Comment on lines
+154
to
+156
| const getLogicMap = () => new Map(); | ||
|
|
||
|
|
Comment on lines
+1840
to
+1846
| .filter(({ options, key }) => { | ||
| if ( | ||
| options?.isReadOnly | ||
| ) | ||
| return false; | ||
| return true; // ← must be OUTSIDE the ee block | ||
| }) |
Comment on lines
+1953
to
+1956
| .filter((widget) => { | ||
| if (widget.options?.isReadOnly) return false; | ||
| return true; // ← outside ee block | ||
| }) |
Comment on lines
+150
to
+151
| let payload = formdata; | ||
| props.handleData(payload); |
Comment on lines
+7
to
16
| const handleWidgetDetails = (value, widgetLabel) => { | ||
| setPrefills((prev) => { | ||
| const widgets = [...(prev ?? [])]; | ||
| const w = widgets[widgetIndex]; | ||
| if (!w) return prev; | ||
| widgets[widgetIndex] = { | ||
| ...w, | ||
| options: { ...w.options, response: value }, | ||
| const index = widgets.findIndex((w) => w?.label === widgetLabel); | ||
| if (index === -1) return prev; | ||
| widgets[index] = { | ||
| ...widgets[index], | ||
| options: { ...widgets[index].options, response: value }, | ||
| response: value | ||
| }; |
raktima-opensignlabs
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #2610 from nxglabs/staging