Skip to content

chore: remove leftover debug console.log statements #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucHeart merged 2 commits into from
Jun 18, 2026
Merged

chore: remove leftover debug console.log statements #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6492be
chore: remove leftover debug console.log statements
hhvrc Jun 18, 2026
a9d3245
Merge branch 'develop' into chore/remove-debug-logs
LucHeart Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/lib/signalr/handlers/DeviceUpdate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { HubUpdateType, isHubUpdateType } from '$lib/signalr/models/HubUpdateType';
import { isHubUpdateType } from '$lib/signalr/models/HubUpdateType';
import { refreshOwnHubs } from '$lib/state/hubs-state.svelte';
import { isString } from '$lib/typeguards';
import { toast } from 'svelte-sonner';
Expand All @@ -10,9 +10,5 @@ export function handleSignalrDeviceUpdate(deviceId: unknown, updateType: unknown
return;
}

const typeLabel = HubUpdateType[updateType];

console.log(`🔄 DeviceUpdate: ${deviceId} → ${typeLabel}`);

refreshOwnHubs();
}
7 changes: 1 addition & 6 deletions src/routes/terminal/EspSerialConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ async function setupESPLoader(
/* empty */
}

console.log('setupESPLoader: ', serialPort);
const transport = new Transport(serialPort);

const flashOptions = {
Expand Down Expand Up @@ -76,8 +75,6 @@ async function setupApplication(serialPort: SerialPort): Promise<SerialPort> {
/* empty */
}

console.log('setupApplication: ', serialPort);

try {
// Need to connect to the ESP32 using the right settings.
// Hardware flow control would be a disaster, as these pins are used to control the device's bootloader.
Expand Down Expand Up @@ -310,7 +307,7 @@ export default class EspSerialConnection {
}
}
} catch (e) {
console.log(e);
console.error(e);
this.terminal.writeLine(`firmware disconnected: ${e}`);
} finally {
try {
Expand Down Expand Up @@ -347,11 +344,9 @@ export default class EspSerialConnection {
}

async disconnect() {
console.log('Disconnecting');
await this._cycleTransport();
this.serialPort = null;
this.terminal.clean();
console.log('Disconnected');
}

async erase() {
Expand Down
Loading