Nhse o32.orkv.i151 usemaps - #12
Open
martinsumner wants to merge 2 commits into
Open
martinsumner wants to merge 2 commits into
martinsumner wants to merge 2 commits into
Conversation
Will randomly select from the top MaxResults set of ID clusters, and any tied with the sparsest set within the MaxResults. This means when there is a contiguous set of IDs (e.g. when doing root_confirm with a fully broken root), any set of IDs will be chosen, not just sets within the first MaxResults. This ensures a better spread of selections across the tree, so that the mismatched_segments will more accurately reflect the overall state of the tree
Uses ordsets due to OTP 22 compatibility requirement wrt v2 support in sets. Is quicker than v2 sets when inputs is sorted (although they may not be)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined fixes back-ported:
martinsumner#126
#11