Repository navigation
fix(frontend): dynamically fetch game summary and player details for OG card (#1348) - #1548
Open
sparkysolutions10-pixel wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves issue #1348 by replacing the hardcoded mock player summary in
frontend/app/api/og/game/[id]/route.tsxwith dynamic backend data fetching.Changes Made
GET /v1/games/{id}using the configured backend API base URL (NEXT_PUBLIC_API_URL/NEXT_PUBLIC_BACKEND_URL).GET /v1/players/{id}in parallel with graceful fallbacks.won,drawn,in progress,waiting,aborted).nullwhenever a game is not found or fails validation, preserving the default branded card fallback.Local Quality Assurance & Verification
Closes #1348