Skip to content

Clean up CodeQL js/ warnings in commons UI #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vharseko merged 1 commit into from
Jul 23, 2026
Merged

Clean up CodeQL js/ warnings in commons UI #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/commons/src/main/js/org/forgerock/commons/ui/common/components/Messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* information: "Portions copyright [year] [name of copyright owner]".
*
* Copyright 2011-2016 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC
*/

define([
Expand Down Expand Up @@ -103,7 +104,7 @@ define([

showMessage: function() {
var _this = this,
alertClass = "alert-info",
alertClass,
alertIcon = "alert-message-icon",
delay = _this.delay + (this.list[0].message.length * 20);

Expand Down
3 changes: 2 additions & 1 deletion ui/commons/src/main/js/org/forgerock/commons/ui/common/main/ViewManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* information: "Portions copyright [year] [name of copyright owner]".
*
* Copyright 2012-2016 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC
*/

define([
Expand Down Expand Up @@ -118,7 +119,7 @@ define([
var cDialog = obj.currentDialog, cDialogArgs = obj.currentDialogArgs;

obj.changeView(obj.currentView, obj.currentViewArgs, function() {}, true);
if (cDialog && cDialog !== null) {
if (cDialog) {
obj.showDialog(cDialog, cDialogArgs);
}
};
Expand Down
2 changes: 1 addition & 1 deletion ui/commons/src/main/js/org/forgerock/commons/ui/common/util/UIUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ define([
* @returns {Boolean}
*/
"isUrl": function(string){
var regexp = /(http|https):\/\/(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(\/|\/([\w#!:.?+=&%@!\-\/]))?/;
var regexp = /(http|https):\/\/(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(\/|\/([\w#!:.?+=&%@\-\/]))?/;
return regexp.test(string);
}

Expand Down
3 changes: 2 additions & 1 deletion ui/commons/src/main/resources/templates/common/LoginTemplate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<!-- Copyright 2016 ForgeRock AS.
Portions Copyrighted 2026 3A Systems, LLC
License terms: https://forgerock.org/cddlv1-0/ -->
<div class="container">
<div class="row">
Expand All @@ -24,7 +25,7 @@
<div class="remember-forgot clearfix">
<div class="checkbox pull-left">
<label>
<input type="checkbox" type="checkbox" name="loginRemember"> {{t "templates.user.LoginTemplate.loginRemember"}}
<input type="checkbox" name="loginRemember"> {{t "templates.user.LoginTemplate.loginRemember"}}
</label>
</div>
</div>
Expand Down
3 changes: 2 additions & 1 deletion ui/user/src/main/js/org/forgerock/commons/ui/user/profile/UserProfileKBATab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* information: "Portions copyright [year] [name of copyright owner]".
*
* Copyright 2015-2016 ForgeRock AS.
* Portions Copyrighted 2026 3A Systems, LLC
*/

define([
Expand Down Expand Up @@ -127,7 +128,7 @@ define([
}

// validate form only in case security question was selected
if (!isKbaQuestion || (isKbaQuestion && (target.val() !== ""))) {
if (!isKbaQuestion || target.val() !== "") {
ValidatorsManager.bindValidators(form, Configuration.loggedUser.baseEntity, function () {
ValidatorsManager.validateAllFields(form);
});
Expand Down
Loading