Skip to content

[#1071] Wrap the sources of the large values PDBStorageTest writes, so that four copies of a 63 MB value are not live at once #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vharseko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[#1071] Wrap the sources of the large values PDBStorageTest writes, so that four copies of a 63 MB value are not live at once #1072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions opendj-server-legacy/src/test/java/org/opends/server/backends/pdb/PDBStorageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ private void reopenWithReplayBounds(int maxRetries, long retryWindowNanos) throw
storage.open(AccessMode.READ_WRITE);
}

/**
* The sources are wrapped rather than copied: a value on its way into Persistit is copied twice more -
* {@code toByteArray()} and the value buffer of the exchange, which doubles up to 64 MB - so with a copy
* here as well the 63 MB value had four copies of itself live at once, on top of the buffer pool and the
* server: about 310 MB left after a collection, in a JVM of 512 MB, which one CI leg ran out of. Wrapped,
* about 165 MB. The three values stay in one transaction on purpose: the value buffer the 32 MB one
* grew fits the 63 MB one without growing again.
*/
@Test
public void testCanAddLargeValues() throws Exception
{
Expand All @@ -148,10 +156,10 @@ public void testCanAddLargeValues() throws Exception
public void run(WriteableTransaction txn) throws Exception
{
txn.openTree(treeName, true);
txn.put(treeName, valueOfUtf8("4mb"), valueOfBytes(new byte[4 * MB]));
txn.put(treeName, valueOfUtf8("32mb"), valueOfBytes(new byte[32 * MB]));
txn.put(treeName, valueOfUtf8("4mb"), wrap(new byte[4 * MB]));
txn.put(treeName, valueOfUtf8("32mb"), wrap(new byte[32 * MB]));
// 64Mb is the maximum allowed for value size. But Persistit has header reducing the payload.
txn.put(treeName, valueOfUtf8("64mb"), valueOfBytes(new byte[63 * MB]));
txn.put(treeName, valueOfUtf8("64mb"), wrap(new byte[63 * MB]));
}
});
}
Expand Down
Loading