Skip to content

Makefile: create BINDIR before installing - #714

Merged
sfchen merged 1 commit into
OpenGene:masterfrom
BenjaminDEMAILLE:makefile-install-mkdir
Sep 1, 2026
Merged

sfchen merged 1 commit into
OpenGene:masterfrom
BenjaminDEMAILLE:makefile-install-mkdir

Conversation

@BenjaminDEMAILLE

Copy link
Copy Markdown
Contributor

make install fails when $(PREFIX)/bin does not exist yet, because install does not create the destination directory:

install fastp /path/to/prefix/bin/fastp
install: /path/to/prefix/bin/fastp: No such file or directory

This shows up in any staged install into a fresh prefix (distro/Homebrew packaging, DESTDIR-style installs, containers), where packagers currently have to mkdir -p the bin directory themselves before calling make install.

Adding mkdir -p $(BINDIR) to the install target fixes it and is a no-op when the directory already exists.

Same patch sent to fastplong: OpenGene/fastplong#44

Tested: make install PREFIX=/tmp/fresh-prefix now succeeds where it previously failed.

`make install` fails when $(PREFIX)/bin does not exist yet, because `install`
does not create the destination directory. Create BINDIR first.
@sfchen
sfchen merged commit dce5c40 into OpenGene:master Sep 1, 2026
2 checks passed
@BenjaminDEMAILLE
BenjaminDEMAILLE deleted the makefile-install-mkdir branch September 1, 2026 11:10
@BenjaminDEMAILLE

Copy link
Copy Markdown
Contributor Author

Thanks for merging.

Any rough timeline for the next tagged release? fastp in Homebrew builds from the release tarball, so until the fix is in a tag the formula keeps a mkdir prefix/"bin" line before make install (see Formula/f/fastp.rb). Once a release carries it, that line can be dropped on the next version bump.

Latest tag is v1.3.6 (2026-06-29) and the fix landed on master on 2026-09-01, so I wanted to ask rather than assume.

@sfchen

sfchen commented Sep 10, 2026

Copy link
Copy Markdown
Member

I will tag a new release very soon

@BenjaminDEMAILLE

Copy link
Copy Markdown
Contributor Author

Thanks !! is it possible to do a release for fastplong for the same thing ?

@sfchen

sfchen commented Sep 11, 2026

Copy link
Copy Markdown
Member

Thanks !! is it possible to do a release for fastplong for the same thing ?

Yes, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants