Makefile: create BINDIR before installing - #714
Merged
Merged
Conversation
`make install` fails when $(PREFIX)/bin does not exist yet, because `install` does not create the destination directory. Create BINDIR first.
7 tasks
Contributor
Author
|
Thanks for merging. Any rough timeline for the next tagged release? fastp in Homebrew builds from the release tarball, so until the fix is in a tag the formula keeps a Latest tag is v1.3.6 (2026-06-29) and the fix landed on master on 2026-09-01, so I wanted to ask rather than assume. |
Member
|
I will tag a new release very soon |
Contributor
Author
|
Thanks !! is it possible to do a release for fastplong for the same thing ? |
Member
Yes, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make installfails when$(PREFIX)/bindoes not exist yet, becauseinstalldoes not create the destination directory:This shows up in any staged install into a fresh prefix (distro/Homebrew packaging, DESTDIR-style installs, containers), where packagers currently have to
mkdir -pthe bin directory themselves before callingmake install.Adding
mkdir -p $(BINDIR)to theinstalltarget fixes it and is a no-op when the directory already exists.Same patch sent to fastplong: OpenGene/fastplong#44
Tested:
make install PREFIX=/tmp/fresh-prefixnow succeeds where it previously failed.