Skip to content

Call getModalComponent after ioComponents are initialized#3774

Open
chpoulter wants to merge 1 commit into
OpenEMS:developfrom
chpoulter:feature/FixIoApiDigitalInputComponent
Open

Call getModalComponent after ioComponents are initialized#3774
chpoulter wants to merge 1 commit into
OpenEMS:developfrom
chpoulter:feature/FixIoApiDigitalInputComponent

Conversation

@chpoulter

@chpoulter chpoulter commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

I noticed that IO state is not shown anymore in the UI. I'm not that deep in angular, but I think this is because modalComponent is created to early. At this point ioComponents is not filled yet.

I move it to the end into the then() of getConfig(). Now it works as expected.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3774      +/-   ##
=============================================
+ Coverage      60.58%   60.61%   +0.03%     
  Complexity       105      105              
=============================================
  Files           3356     3356              
  Lines         146350   146350              
  Branches       10852    10852              
=============================================
+ Hits           88655    88693      +38     
+ Misses         54367    54321      -46     
- Partials        3328     3336       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant