Call getModalComponent after ioComponents are initialized#3774
Open
chpoulter wants to merge 1 commit into
Open
Call getModalComponent after ioComponents are initialized#3774chpoulter wants to merge 1 commit into
chpoulter wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3774 +/- ##
=============================================
+ Coverage 60.58% 60.61% +0.03%
Complexity 105 105
=============================================
Files 3356 3356
Lines 146350 146350
Branches 10852 10852
=============================================
+ Hits 88655 88693 +38
+ Misses 54367 54321 -46
- Partials 3328 3336 +8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that IO state is not shown anymore in the UI. I'm not that deep in angular, but I think this is because modalComponent is created to early. At this point ioComponents is not filled yet.
I move it to the end into the then() of getConfig(). Now it works as expected.