-
-
Notifications
You must be signed in to change notification settings - Fork 31
feat(core): add protobuf asset support, npc spawns, and map zones #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
4309d44
d281485
da19d65
73049d5
35e600e
54aa0e4
d7ea280
69d6481
684c717
65befd4
c52981d
e519c4b
02750cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,4 +127,4 @@ compile_commands.json | |
| /assets | ||
| /build-ninja-codex/vcpkg_installed | ||
| /build-ninja-codex | ||
|
|
||
| /protobuf | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -234,7 +234,7 @@ version = 830 | |
|
|
||
| [[clients]] | ||
| configType = 'dat_otb' | ||
| datSignature = '493D607A' | ||
| datSignature = '467FD7E6' | ||
| dataDirectory = '840' | ||
| description = 'sample description' | ||
| extended = false | ||
|
|
@@ -245,7 +245,7 @@ name = '8.40' | |
| otbId = 12 | ||
| otbMajor = 3 | ||
| otbmVersions = [ 3 ] | ||
| sprSignature = '493D4E7C' | ||
| sprSignature = '467F9E74' | ||
| spritesFile = 'Tibia.spr' | ||
| transparency = false | ||
| version = 840 | ||
|
|
@@ -342,10 +342,10 @@ version = 855 | |
|
|
||
| [[clients]] | ||
| configType = 'dat_otb' | ||
| datSignature = '4C2C7993' | ||
| datSignature = '4C28B721' | ||
| dataDirectory = '860' | ||
| description = 'sample description' | ||
| extended = true | ||
| extended = false | ||
| frameDurations = false | ||
| frameGroups = false | ||
| metadataFile = 'Tibia.dat' | ||
|
|
@@ -1115,20 +1115,20 @@ transparency = true | |
| version = 1310 | ||
|
|
||
| [[clients]] | ||
| configType = 'dat_otb' | ||
| configType = 'protobuf' | ||
| datSignature = '4A10' | ||
| dataDirectory = '1320' | ||
| dataDirectory = 'canary' | ||
| description = 'sample description' | ||
| extended = true | ||
| frameDurations = true | ||
| frameGroups = true | ||
| metadataFile = 'Tibia.dat' | ||
| name = '13.20' | ||
| metadataFile = 'appearances-ec29a245e364f190682aa3677ca04f657cb9a2076eca5fc931d039bab8c32887.dat' | ||
| name = 'canary2' | ||
| otbId = 66 | ||
| otbMajor = 3 | ||
| otbmVersions = [ 3 ] | ||
| otbmVersions = [ 5, 6 ] | ||
| sprSignature = '59E48E02' | ||
| spritesFile = 'Tibia.spr' | ||
| spritesFile = 'assets/catalog-content.json' | ||
| transparency = true | ||
| version = 1320 | ||
|
|
||
|
|
@@ -1187,20 +1187,20 @@ transparency = false | |
| version = 77 | ||
|
|
||
| [[clients]] | ||
| configType = 'dat_only' | ||
| datSignature = '42A3' | ||
| configType = 'protobuf' | ||
| datSignature = '0' | ||
| dataDirectory = 'canary' | ||
| description = 'sample description' | ||
| extended = true | ||
| frameDurations = true | ||
| frameGroups = true | ||
| metadataFile = 'Tibia.dat' | ||
| name = '10.98dat' | ||
| metadataFile = 'appearances-eb398f6272e1a0bf9e09c8a5754dbdb28017ef303fc3a0859a6b230640d91c9b.dat' | ||
| name = 'canary' | ||
| otbId = 57 | ||
| otbMajor = 3 | ||
| otbmVersions = [ 3 ] | ||
| sprSignature = '57BBD603' | ||
| spritesFile = 'Tibia.spr' | ||
| otbmVersions = [ 5, 6 ] | ||
| sprSignature = '0' | ||
| spritesFile = 'assets/catalog-content.json' | ||
| transparency = false | ||
| version = 1098 | ||
|
|
||
|
|
@@ -1219,5 +1219,23 @@ otbMajor = 3 | |
| otbmVersions = [ 3 ] | ||
| sprSignature = '57BBD603' | ||
| spritesFile = 'Tibia.spr' | ||
| transparency = true | ||
| version = 1098 | ||
|
|
||
| [[clients]] | ||
| configType = 'dat_otb' | ||
| datSignature = '0' | ||
| dataDirectory = '1287' | ||
| description = '' | ||
| extended = false | ||
| frameDurations = false | ||
| frameGroups = false | ||
| metadataFile = 'Tibia.dat' | ||
| name = 'New Client' | ||
| otbId = 0 | ||
| otbMajor = 1 | ||
| otbmVersions = [] | ||
| sprSignature = '0' | ||
| spritesFile = 'Tibia.spr' | ||
| transparency = false | ||
| version = 1098 | ||
| version = 0 | ||
|
Comment on lines
+1225
to
+1241
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New client entry appears to be a template/placeholder. The new client Consider removing this entry or completing the configuration if it's intended for a specific client version. 🤖 Prompt for AI Agents |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid ignoring the entire
/protobufsource directoryLine 130currently ignores/protobufwholesale. That can accidentally exclude.protoschema sources from git, which can break reproducibility for CI and other developers. Prefer ignoring only generated outputs (e.g., specific*.pb.*files or build-output paths) instead of the whole directory.Suggested `.gitignore` adjustment
📝 Committable suggestion
🤖 Prompt for AI Agents