Skip to content

Correct tool effects and remove download credential arguments - #228

Merged
silverstein merged 2 commits into
masterfrom
fix/openai-review-20261020
Oct 20, 2026
Merged

silverstein merged 2 commits into
masterfrom
fix/openai-review-20261020

Conversation

@silverstein

@silverstein silverstein commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Correct prepare_lumin_request stateful/non-idempotent annotations.
  • Neutralize download descriptions and remove arbitrary HTTP headers from schema and runtime. Unknown arguments fail before URL/path/network work without reflecting names or values.
  • Preserve source/share parity and update measured live tool-contract pins.
  • Document private encrypted-PDF credential entry as a proposal only. Existing password arguments remain.

Verification

Silverbook macOS26.6 arm64 Node22.23.2:179/179 tests across six focused/adjoining suites passed. Syntax and diff checks passed. Independent source and generated-package review passed.

Exact generated package1686ad386e55e5e5ac21995e77dce268f8a8b1b4 is in pdf-tools-plugin draftPR1. Its contained launcher passed61-tool fingerprint, three credential-refusal cases, public form reading and page rendering. Both runtime Git blobs equal source exactly; five package files changed. Production plugin main unchanged.

Full CI is reported by checks, not inferred from focused evidence. No native ChatGPT UI acceptance, public release, provider operation or submission approval claimed. Password-entry implementation remains separate from its proposal.

@silverstein
silverstein merged commit 697b5a2 into master Oct 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant