Repository navigation
Preserve fully evidenced header-neutral table grids - #224
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Add a default-off
allow_headerless_tablesoption toconvert_pdf_to_markdown.When complete cell-rectangle geometry and source coverage support a grid but
do not establish a header row, the opted-in profile preserves escaped HTML
data cells rather than inventing Markdown header semantics.
Ordinary calls and explicit false retain the complete previous envelope and
renderer 1.21.0. Opted-in calls identify renderer 1.22.0 and retain a typed
header-role uncertainty gap and partial status. No new tool, OCR or model call.
Boundaries
assignment, full text-box containment and complete retained evidence.
tdcells, no headers, spans, inherited values or semantic blanks.Independent review found and closed a source-row omission and unsafe-text
sanitation bypass before this final candidate. Additional review accepted the
final bounded source and tests. The existing broader table-topology, scan and
equation limitations are not solved by this option.
Verification
81b7400a9d7bd9b544357d836e917cce258cdd71.338 tests passed, zero failures. Includes actual synthetic PDF/MCP conversion,
both optional flags, outside-grid/disjoint-grid retention, unsafe text,
URL neutralization, source/schema/contract and neighboring table verifiers.
occurrence oracle. Regeneration and independent review verified that only
two module size/hash records and their aggregate hash changed. All eight
cases, expected facts, layout bindings and scoring rules are unchanged.
The three affected Mac files then passed 20/20 tests. No test was waived.
bytes, SHA-256
bb4728da1390d39a5d2b27f5c3b992ec08b4cdc27b9f2dc70e0902d3a4497140.verified the new HTML option, unchanged default envelope, both optional flags,
source-byte preservation and invalid-argument rejection.
Build/native checks ran at the preceding runtime-identical f8b97b5;
the successor changes only the nonpackaged oracle metadata. The packed new-
option probe was repeated successfully at final 81b7400.
the two third-shard runners lost communication without test conclusions or
downloadable logs. One unchanged-source targeted rerun passed both jobs.
The cause remains unproven and is separately tracked, not called a source fix.
npm run test:allpassed at final 81b7400,actual exit 0: 213 Vitest files / 4,158 tests passed, seven files / 109
conditional tests skipped; native partition 99 passed / nine conditional
skips / zero failures. No filters, budget changes or timing skips were used.
Aggregate source barriers and final manual Git check confirm clean exact HEAD.
This is bounded source behavior and synthetic evidence, not installed desktop,
Windows, release or comparative benchmark acceptance. The historical default
text-only benchmark is unchanged and has not been rescored.
See Header-neutral tables for the option and limits.