Get cleaner from cache#960
Merged
Merged
Conversation
rafalste
force-pushed
the
ocf_cache_get_cleaner
branch
from
489ead0 to
053c9c9
Compare
robertbaldyga
requested changes
Jun 19, 2026
Comment on lines
+295
to
+299
| if (!ocf_cache_is_device_attached(cache)) | ||
| return NULL; | ||
|
|
||
| if (cache->conf_meta->cleaner_disabled) | ||
| return NULL; |
Member
There was a problem hiding this comment.
Also this (and doc update):
if (ocf_cache_is_standby(cache))
return NULL;BTW this function this is the first place where we introduce ocf_cleaner_t nullability, but I think API-wise it is ok.
Contributor
Author
There was a problem hiding this comment.
Any other doc for this change then the one in header?
Needed by SPDK OCF module to set/get CPU mask on cleaner thread. Signed-off-by: Rafal Stefanowski <r.stefanowski@pm.me>
rafalste
force-pushed
the
ocf_cache_get_cleaner
branch
from
053c9c9 to
9b10446
Compare
robertbaldyga
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by SPDK OCF module to set/get CPU mask on cleaner thread.