fix: Enable FLAC and LZMA definitions for rcheevos CHD hashing#8
Open
fativi wants to merge 1 commit into
Open
Conversation
Onion OS strips the translation block that converts Makefile variables (HAVE_FLAC) to C-preprocessor macros (-DHAVE_FLAC) for the libchdr engine. This explicitly passes the required definitions so dr_flac.h is included, fixing the 'Could not open track' error when RetroAchievements attempts to hash compressed CHD files.
fativi
force-pushed
the
fix-rcheevos-chd-flac
branch
from
July 18, 2026 04:42
f6dfe59 to
6f1e2b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onion OS strips the translation block that converts Makefile variables (HAVE_FLAC) to C-preprocessor macros (-DHAVE_FLAC) for the libchdr engine. This explicitly passes the required definitions so dr_flac.h is included, fixing the 'Could not open track' error when RetroAchievements attempts to hash compressed CHD files.