Overlap launch preparation - #1946
Open
robcodedev wants to merge 1 commit into
Open
Conversation
Two things in launch_game block on work that nothing after them depends on. playActivity start now runs in the background alongside the config patching, and the pgrep-then-kill loop over five service names becomes one backgrounded killall. Both are joined before cmd_to_run.sh runs, and on the file-not-found path. The miyoocmd path sets is_game=0, so neither job is started there and there is nothing to join.
Copilot AI
added a commit
to Amiga500/Onion
that referenced
this pull request
Sep 9, 2026
…1943 OnionUI#1944 OnionUI#1945 OnionUI#1946 (runtime.sh, keymon, lt.lang) Co-authored-by: Amiga500 <16525337+Amiga500@users.noreply.github.com>
Amiga500
added a commit
to Amiga500/Onion
that referenced
this pull request
Sep 9, 2026
Port OnionUI PRs OnionUI#1936–OnionUI#1946 (launch prep, fb transitions, GameSwitcher favorites/crash fixes, theme previews) — thanks @robcodedev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
launch_gameruns two pieces of preparation strictly in sequence with work that does not depend on them.playActivity startcompletes before config patching begins, and services are killed one name at a time - apgrepand akillper name, five names, all before the launch proceeds.What this does
playActivity startis backgrounded and runs alongside the config patching. The kill loop becomes a single backgroundedkillallover all five names.Both jobs are joined before
cmd_to_run.shruns, and on the file-not-found path. Themiyoocmdpath leavesis_game=0, so neither job is started there and both PIDs are empty where no join exists.This is a scheduling change only from runtime's point of view: the same services are targeted, and activity tracking and service shutdown still complete before the emulator is handed control.
Testing
Launched games from MainUI and from GameSwitcher, confirmed play time is recorded.