Repository navigation
fix(ask-chat): regenerate an artifact in its own workspace, env and mode - #93
Merged
Merged
Conversation
Both regenerate buttons (Regenerate, and Apply & Regenerate in the edit panel) built the request with the sidebar's workspace, env and mode. The gallery shows only the sidebar's workspace and env and closes the viewer when either changes, which hid most of it, but the mode could still change under an open artifact, and any path that kept the viewer open would have regenerated a prod artifact from the dev database while keeping its prod label. Both now send the artifact's own request: Regenerate unchanged, Apply & Regenerate with the edited name, purpose, data focus and format only. A regeneration that finishes after the sidebar moved is saved in its own workspace and env and no longer reopens the viewer there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both regenerate buttons in the artifact viewer (Regenerate, and Apply & Regenerate in the edit panel) sent the sidebar's workspace, env and mode instead of the artifact's. #91 scoped the gallery to the sidebar and closes the viewer when the workspace or env changes, which hid most of it, but:
Change
Frontend only (
ArtifactsPage.tsx):_request; the edit panel changes name, purpose, data focus and format, never where it runs.03-artifacts.md): Regenerate and Apply & Regenerate run in the artifact's own workspace, environment and mode.No backend change:
POST /v1/artifactalready takes the scope from the request body.Tests
ask-chat has no test runner: typecheck, lint and build pass. To be checked by hand on the GONAC PoC server.
🤖 Generated with Claude Code