Skip to content

Fix short-line route schedules - #597

Open
soumajitgh wants to merge 3 commits into
OneBusAway:developfrom
soumajitgh:fix/short-line-schedules
Open

Fix short-line route schedules#597
soumajitgh wants to merge 3 commits into
OneBusAway:developfrom
soumajitgh:fix/short-line-schedules

Conversation

@soumajitgh

@soumajitgh soumajitgh commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • label short-line departures with their trip destination
  • replace blank schedules with a retryable load error state
  • guard schedule endpoint against unavailable upstream responses

Desing

image

Testing

  • npm test -- --run src/tests/api/schedule-for-stop.test.js src/components/schedule-for-stop/tests/RouteScheduleTable.test.js
  • npm run lint:eslint
  • npm run build

Fixes #251

Use per-trip stop headsigns so riders can identify trips that terminate early.

Fixes OneBusAway#251
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 52 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1eb56aa6-7c62-4554-8025-2079200d6f7d

📥 Commits

Reviewing files that changed from the base of the PR and between 1fd4dd8 and def586b.

📒 Files selected for processing (6)
  • src/components/schedule-for-stop/RouteScheduleTable.svelte
  • src/components/schedule-for-stop/__tests__/RouteScheduleTable.test.js
  • src/locales/en.json
  • src/routes/api/oba/schedule-for-stop/[stopId]/+server.js
  • src/routes/stops/[stopID]/schedule/+page.svelte
  • src/tests/api/schedule-for-stop.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soumajitgh
soumajitgh marked this pull request as ready for review August 24, 2026 05:00
@coveralls

coveralls commented Aug 24, 2026

Copy link
Copy Markdown

Coverage Status

Coverage is 93.248%soumajitgh:fix/short-line-schedules into OneBusAway:develop. No base build found for OneBusAway:develop.

@soumajitgh

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 53 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When viewing the Route Schedule, short-lines aren't handled properly

2 participants