Skip to content

fix(analytics): handle missing event envelope - #593

Open
soumajitgh wants to merge 1 commit into
OneBusAway:developfrom
soumajitgh:fix/333-forward-event-no-args
Open

fix(analytics): handle missing event envelope#593
soumajitgh wants to merge 1 commit into
OneBusAway:developfrom
soumajitgh:fix/333-forward-event-no-args

Conversation

@soumajitgh

Copy link
Copy Markdown
Contributor

Summary

  • default Plausible event envelopes to an empty object
  • return the existing clear validation error for no-argument calls
  • document the intentional disabled-before-validation behavior

Testing

  • npm test -- --run src/tests/lib/Insights/adapters/PlausibleAdapter.test.js src/tests/api/events.test.js
  • npx prettier --check src/lib/Insights/adapters/PlausibleAdapter.js src/tests/lib/Insights/adapters/PlausibleAdapter.test.js

Closes #333

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@soumajitgh, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0586ac6c-a0ca-46e9-85b2-19f1aa3945fa

📥 Commits

Reviewing files that changed from the base of the PR and between 1fd4dd8 and 842a68a.

📒 Files selected for processing (2)
  • src/lib/Insights/adapters/PlausibleAdapter.js
  • src/tests/lib/Insights/adapters/PlausibleAdapter.test.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 93.248%soumajitgh:fix/333-forward-event-no-args into OneBusAway:develop. No base build found for OneBusAway:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analytics: follow-up improvements from PR #332 review

2 participants