Repository navigation
ci: name every artifact after the release file it holds - #570
Merged
Merged
Conversation
Artifact names mixed platform spellings, carried a commit suffix only outside releases, and said nothing about the files inside them (app-release.apk). An installable artifact is now named after its release file, without openaide- and the version: vscode-<target>, desktop-windows-x64, desktop-macos-arm64, android, android-debug and app-server-android-arm64. Failure-only uploads end in -diagnostics. The -g<sha> suffix is gone: artifacts are scoped to their run, and the file inside already carries the version. The Termux runtime is the Android App Server, so it is published as openaide-app-server-android-arm64-VERSION.tar.gz, like the Linux archive. The app reads only the release matching its own version, so apps installed from earlier releases keep finding openaide-termux-arm64.tar.gz there. Setup reports every lookup failure the same way, so the lookup now logs its outcome with a fixed reason. The README, CODE_SIGNING.md and the release policy still listed the Desktop files as -unsigned and -unnotarized; they now give the real names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Artifact names now follow one rule: an installable artifact is named after the release file it holds, without
openaide-and the version. Failure-only uploads end in-diagnostics.vsix-<target>-g<sha>vscode-<target>openaide-vscode-<target>-VERSION.vsixdesktop-win32-x64-g<sha>desktop-windows-x64openaide-desktop-windows-x64-VERSION.exedesktop-darwin-arm64-g<sha>desktop-macos-arm64openaide-desktop-macos-arm64-VERSION.dmgandroid-userandroidopenaide-android.apk(wasapp-release.apk)android-debugandroid-debugopenaide-android-debug.apk(wasapp-debug.apk)android-app-server-arm64app-server-android-arm64openaide-app-server-android-arm64.tar.gzapp-server-<target>-g<sha>app-server-<target>android-reports,android-browser-checksandroid-apk-diagnostics,android-browser-diagnostics-g<sha>suffix and theartifact_suffixinput are removed. Artifacts are scoped to their run, and the file inside already carries the version.Android App Server release asset
The Termux runtime is the Android App Server, so new releases publish it as
openaide-app-server-android-arm64-VERSION.tar.gzinstead ofopenaide-termux-arm64.tar.gz, matchingopenaide-app-server-linux-x64-VERSION.tar.gz. The internal archive layout is unchanged.The app reads only the release matching its own version. Apps installed from earlier releases keep reading those immutable releases, which still contain
openaide-termux-arm64.tar.gz. Setup reports every lookup failure as an unavailable download, soRuntimeReleasenow logsruntime_release_lookupstart and end events with a fixed reason code.Docs
The README,
CODE_SIGNING.mdanddocs/release-policy.mdstill listed the Desktop files as-unsignedand-unnotarized. They now give the real names. The Android README describes the current artifacts.Verification
node --test scripts/test-workspace-gate.test.mjspasses, with new assertions for the artifact and release asset names.RuntimeReleaseTestandBundledRuntimeTestpass locally, including a new asset-name test.main.npm run check:private-datapasses.