Conversation
godzillaba
marked this pull request as ready for review
March 21, 2025 19:34
gzeoneth
reviewed
Apr 2, 2025
Member
There was a problem hiding this comment.
LGTM, I think we should add an onlyOwner rescue function that allow arbitrary call (except to the token contract, or send eth in the token=0 case) to save fund that are mistakenly sent to this contract, as I can see that might happen due to people not realizing each reward distributor only accept a specific token.
Contributor
Author
|
#58 covers the rescue comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.