Fill in four stub landing pages and restore the missing preview banner - #49
Merged
Conversation
Four section landing pages under launch-arbitrum-chain/configuration had a byte-identical body — same SHA1 across core, costs, data-availability and sequencer — under four different titles. All rendered the same three cards (Layer Leap, Sequencer timing adjustments, DA API integration), none of which belongs to the section, so "Fees and costs" advertised Layer Leap. They were unfilled codemod stubs. Each now lists its own children, ordered by the section's meta.json and described from each child's own frontmatter: core 5 cards, costs 11, data-availability 4 (three pages plus the DAC subsection), sequencer 7. Frontmatter is untouched. Also restores the public-preview banner. public-preview-expectations.mdx read "disclaimers that look like this:" and then, with nothing between, "This banner's purpose is…" — the partial existed but was included nowhere, so the page pointed at an element that was not there. partials:check has no unused-partial rule, so nothing caught it. Adds docs/code-review-backlog.md recording the review findings left for later, including three that need a product decision (the 440-site VanillaAdmonition/Callout overlap, the 7 partials orphaned by the FloatingHoverModal deletion, and the 5 no-op FAQStructuredData call sites). Verified: all seven blocking gates pass, and check-links holds at 15 — so every one of the 27 new hrefs resolves. Banner render confirmed in a browser (frontmatter stripped, no literal <include> leaked).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
FloatingHoverModal ESM-imported 18 partials. Nine (`*-pc.mdx`) are also <include>d by a live choose-*.mdx page and stay reachable; the other nine had no second consumer. The first count said seven because the scan searched the whole repo and treated prose mentions in .claude/ planning docs as references. _config-evm-compatibility.mdx and _config-l1-challenge-period.mdx are only named in a plan doc and registry.json, neither of which renders anything. Records both traps for the next reader: exclude .claude/ when judging reachability, and match the basename literally — a regex like `include[^>]*<basename>` matches nothing, because `<include cwd>` itself contains a `>`.
Claude-related documentation belongs under .claude/docs/, alongside the existing superpowers specs and plans, not in a top-level docs/ tree. The now-empty docs/ directory is removed. File contents unchanged; git records it as a rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action 2 from the codebase review, plus the backlog file for everything deferred.
Four landing pages were byte-identical stubs
launch-arbitrum-chain/configuration/{core,costs,data-availability,sequencer}/index.mdxhad the same body SHA1 under four different titles, all rendering the same three cards — Layer Leap, Sequencer timing adjustments, DA API integration — none of which belongs to the section. So "Fees and costs" advertised Layer Leap. Unfilled codemod stubs.Each now lists its own children, ordered by the section's
meta.jsonand described from each child's own frontmatter — derived from the content, not invented: core 5 cards, costs 11, data-availability 4 (three pages plus the DAC subsection), sequencer 7. Frontmatter is untouched.The public-preview banner was missing
overview/public-preview-expectations.mdxread "…disclaimers that look like this:" and then, with nothing in between, "This banner's purpose is…". The partial existed but was included nowhere, so the page pointed at an element that was not there.partials:checkhas no unused-partial rule, so nothing caught it..claude/docs/code-review-backlog.md
Records the review findings left for later, with the verifying command for each. Three need a product decision rather than a cleanup:
VanillaAdmonition/Calloutoverlap (Calloutis registered and used zero times)FloatingHoverModaldeletion in Remove dead code left by the Docusaurus migration #48FAQStructuredDatacall sites thatconsole.warnand render nothingOn that middle item:
FloatingHoverModalESM-imported 18 partials. Nine (*-pc.mdx) are also<include>d by a livechoose-*.mdxpage and stay reachable; the other nine had no second consumer. An earlier revision of this file said seven — that count wrongly treated prose mentions inside.claude/planning docs as references. The backlog records both traps: exclude.claude/when judging reachability, and match the basename literally, since a regex likeinclude[^>]*<basename>matches nothing (<include cwd>itself contains a>).Verification
All seven blocking gates pass.
check-linksholds at 15 — unchanged — which is what proves all 27 new hrefs resolve; a single bad card link would have pushed it to 16.Banner render confirmed in a browser: frontmatter stripped, no literal
<include>leaked, no stray:::orundefined. Thecostspage now links only into its own section (Layer Leap and DA API gone).