Skip to content

HYRAX-2151: Add CI for notebooks#23

Merged
hannahilea merged 27 commits into
mainfrom
hr/ci-for-tutorials
May 13, 2026
Merged

HYRAX-2151: Add CI for notebooks#23
hannahilea merged 27 commits into
mainfrom
hr/ci-for-tutorials

Conversation

@hannahilea
Copy link
Copy Markdown
Contributor

@hannahilea hannahilea commented May 12, 2026

Paired w/ @Mikejmnez to add a GHA runner that runs each notebook in sequence, and then fails if any of the notebooks failed to run to completion.

Note that we are currently running against PROD. If we want to run these notebooks against a pre-deployment hyrax (including SIT or UAT), we'll need to do additional work. As a first step, we deemed running against PROD sufficient.

Triggers for this CI job:

Failure notifications are not handled in any special way; users can subscribe to failures in the same way they subscribe to any other github repo CI.

@hannahilea hannahilea marked this pull request as ready for review May 12, 2026 18:00
@hannahilea
Copy link
Copy Markdown
Contributor Author

Note that the current CI failure is due to this new job correctly catching failing notebooks! @Mikejmnez is fixing those now, so we can make sure this job passes.

Copy link
Copy Markdown
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

FWIW, testing against UAT should be pretty easy since it's open to the public. You will need a UAT EDL login, but after that it should be just like the PROD server (except that the data are flakey and move all the time).

@hannahilea
Copy link
Copy Markdown
Contributor Author

(except that the data are flakey and move all the time).

Yeah---I think all the tutorials here would have to be updated to grab UAT test data, which is non-ideal? 🤷 So I think that maybe for now, testing against PROD is fine, and that if we want to test this against SIT we could run these same tests in bamboo.

@hannahilea
Copy link
Copy Markdown
Contributor Author

Filed #28 , and updated our failure check to fail if MORE THAN ONE notebooks fail, as we currently expect the single MERRA2 notebook to fail.

@Mikejmnez
Copy link
Copy Markdown
Collaborator

Mikejmnez commented May 13, 2026

Filed #28 , and updated our failure check to fail if MORE THAN ONE notebooks fail, as we currently expect the single MERRA2 notebook to fail.

Hmm. I think we should have ci/cd fail if there is at least one notebook that fails. We can configure CI/CD to skip that notebook since we know if fails. But ci/cd should be there to flag any issues with any notebook

Sounds good with me

@hannahilea hannahilea merged commit 76efa8b into main May 13, 2026
1 check passed
@hannahilea hannahilea deleted the hr/ci-for-tutorials branch May 13, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants