HYRAX-2151: Add CI for notebooks#23
Conversation
|
Note that the current CI failure is due to this new job correctly catching failing notebooks! @Mikejmnez is fixing those now, so we can make sure this job passes. |
jgallagher59701
left a comment
There was a problem hiding this comment.
Looks good.
FWIW, testing against UAT should be pretty easy since it's open to the public. You will need a UAT EDL login, but after that it should be just like the PROD server (except that the data are flakey and move all the time).
Yeah---I think all the tutorials here would have to be updated to grab UAT test data, which is non-ideal? 🤷 So I think that maybe for now, testing against PROD is fine, and that if we want to test this against SIT we could run these same tests in bamboo. |
|
Filed #28 , and updated our failure check to fail if MORE THAN ONE notebooks fail, as we currently expect the single MERRA2 notebook to fail. |
Sounds good with me |
Paired w/ @Mikejmnez to add a GHA runner that runs each notebook in sequence, and then fails if any of the notebooks failed to run to completion.
Note that we are currently running against PROD. If we want to run these notebooks against a pre-deployment hyrax (including SIT or UAT), we'll need to do additional work. As a first step, we deemed running against PROD sufficient.
Triggers for this CI job:
Failure notifications are not handled in any special way; users can subscribe to failures in the same way they subscribe to any other github repo CI.