Remove hard-coded credentials from docker-compose.yml - #289
Merged
Conversation
Copilot
AI
changed the title
[WIP] Remove hard-coded credentials from docker_compose.yaml
Remove hard-coded credentials from docker-compose.yml
Jul 22, 2026
barnstee
approved these changes
Jul 22, 2026
barnstee
marked this pull request as ready for review
July 22, 2026 06:31
barnstee
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-compose.ymlshipped hard-coded PostgreSQL, service, and pgAdmin credentials. These are now supplied via environment variables loaded from a git-ignored.envfile.Changes
docker-compose.yml— Replaced literal credentials with${VAR}substitutions across all three services:${POSTGRESQL_USERNAME}/${POSTGRESQL_PASSWORD}/${POSTGRESQL_DATABASE}ServicePassword→${SERVICE_PASSWORD}POSTGRES_USER/PASSWORD/DB, pgAdminPGADMIN_DEFAULT_EMAIL/PASSWORD, and the pgpassfile entrypoint line.env.example— New template enumerating the required variables; developers copy it to.env..gitignore— Ignore.envso real credentials stay out of source control.README.md— Development setup now includes the copy-.env.example-to-.envstep.Notes
.env.exampleretains the prioruacloudlibdefaults purely as placeholder values for local dev convenience; the actual.envis untracked.docker compose configresolves all variables from.envas expected.