Wait for HTTPS listener readiness in integration tests - #4313
Wait for HTTPS listener readiness in integration tests#4313marcschier with Copilot wants to merge 4 commits into
Conversation
|
|
Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR hardens the RealHttpsListenerIntegrationTests fixture by ensuring the Kestrel-backed HTTPS listener is actually accepting TCP connections before the first test request is sent, addressing an intermittent macOS flake in the real HTTPS round-trip tests.
Changes:
- Added a post-
OpenAsyncreadiness probe that attempts loopback TCP connects until the listener accepts or a deadline is reached. - Deferred
HttpClientcreation until after listener readiness is confirmed.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Code coverage✅ Coverage gate passed.
Coverage is above the recorded baseline - consider ratcheting Thresholds live in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4313 +/- ##
==========================================
- Coverage 80.30% 80.30% -0.01%
==========================================
Files 1927 1927
Lines 263492 263492
Branches 46101 46101
==========================================
- Hits 211597 211590 -7
- Misses 35650 35669 +19
+ Partials 16245 16233 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@copilot fix ci |
Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
Description
The real HTTPS listener test could issue its first request before Kestrel accepted connections, causing intermittent macOS failures.
OpenAsync.Related Issues
Checklist