imx: integrate PHYTEC imx8m boards#840
Closed
ymoog wants to merge 4 commits intoOP-TEE:masterfrom
Closed
Conversation
Binman handles all calls to mkimage and is called when building an U-Boot image. Thus nothing more needs to be done and most of the mkimage section can be dropped. Also introduce a variable for a SoC specific seek value when flashing the bootloader image to mmc. Signed-off-by: Yannic Moog <y.moog@phytec.de>
U-Boot adds an optee node to device tree for imx8m. If a node is present or created before the U-Boot is called, board will fail to boot with "Could not create optee node." (ft_add_optee_node in mach-imx/imx8m/soc.c) Make existing imx8m family boards use the script by introducing new variable. imx8mq-evk will keep the existing script. Signed-off-by: Yannic Moog <y.moog@phytec.de>
phyBOARD-Pollux is an imx8mp board of the imx8m family. Signed-off-by: Yannic Moog <y.moog@phytec.de>
WIP Signed-off-by: Yannic Moog <y.moog@phytec.de>
jforissier
reviewed
Jul 28, 2025
Contributor
jforissier
left a comment
jforissier
left a comment
There was a problem hiding this comment.
- For "imx: update makefile to binman":
s/mmc/MMC/ in the commit description + one comment below. With that:
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
| #> +If you want to run with HDMI, copy signed_hdmi_imx8m.bin to imx-mkimage/iMX8M | ||
| #> +make SOC=iMX8M flash_spl_uboot or make SOC=iMX8M flash_hdmi_spl_uboot to | ||
| #> +generate flash.bin. | ||
| mkimage-clean: |
Contributor
There was a problem hiding this comment.
Is this target still useful?
Author
There was a problem hiding this comment.
No, don't think it is, should be removed probably. I also thought about removing mk-image from the imx manifest then as I don't think it is used anymore.
jforissier
reviewed
Jul 28, 2025
Contributor
jforissier
left a comment
jforissier
left a comment
There was a problem hiding this comment.
- For "imx: create imx8m boot script":
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
jforissier
reviewed
Jul 28, 2025
Contributor
jforissier
left a comment
jforissier
left a comment
There was a problem hiding this comment.
- For "imx: add phyBOARD-Pollux":
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed pull request at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to integrate phytec imx8m boards to the build framework.
For full build support, the imx manifest needs to be updated as well. OP-TEE/manifest#330
Note that for everything to work, we need to wait for U-Boot 2025.10 release since U-Boot work for imx8m phytec boards as a prerequisite is still ongoing.
The challenge is finding a common method that multiple vendors share (nxp, toratex, phytec) regarding
Propose using U-Boot standard boot as well as binman.
Before, imx-mkimage was used to package all firmware blobs into a boot container, now use binman which handles packaging.
Further, U-Boot standardboot sets forth variables (that must be defined when using standard boot) that hold addresses for where to load kernel,initramfs,dtb.
Thus we can migrate from required "proprietary" variables (mmcdev, mmcpart, mmcargs, loadfdt, loadimage) and define them ourselfs in the boot script.
Note that U-Boot standard boot is recommended for all new boards in U-Boot, so expecting standard boot to be used here is a good idea going forward.