fix: use public runner label for Extended Validation workflow - #138
Open
daedalus-omt wants to merge 1 commit into
Open
fix: use public runner label for Extended Validation workflow#138daedalus-omt wants to merge 1 commit into
daedalus-omt wants to merge 1 commit into
Conversation
The repo is public but the extended-validation.yml workflow requests private runners, causing all queued runs to idle indefinitely when no idle private-labeled runner is available. The four existing idle synology-public runners cannot match because "private" is a required label. Change runs-on from [self-hosted,synology,shell-only,private] to [self-hosted,synology,shell-only public] on all 5 jobs so the public runner fleet can pick up Extended Validation runs.
athena-omt
requested changes
Aug 13, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Request changes — the public runner label matches four idle synology-public runners, but this head is not ready to merge.
- Actionlint fails on
.github/workflows/extended-validation.ymlbecause no actionlint configuration declares the custom self-hosted labels, including the newly addedpublic. Add anactionlint.yamlrunner-label configuration coveringsynology,shell-only,private, andpublic, then rerun CI. - Update/rebase this branch onto current
main(8a442aa5358b6a774bd7d319da4da0a0e3cf9eb5) and wait for fresh checks before re-review. The branch is 36 commits behind.
No prior reviews or unresolved review threads were present. The exact-head worktree diff is whitespace-clean; targeted metadata fixture tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repo is public, but
.github/workflows/extended-validation.ymluses theprivaterunner label on all 5 jobs. Queue run 31577310991 has been idle since 2026-08-13T08:16:16Z because the four idlesynology-publicrunners cannot match (privateis a required label).Fix
Changed
runs-onfrom['self-hosted', 'synology', 'shell-only', 'private']to
['self-hosted', 'synology', 'shell-only', 'public']on all 5 jobs:
changes,fast-checks,extended-checks,validate-secrets,extended-validation-gate.Validation
actionlintpasses on the workflow file (exit 0)..github/workflows/extended-validation.yml— no runner groups, visibility, labels, or main changed.Scope
This change is safe for a public repo: it aligns the workflow with the existing idle public-labeled runner fleet rather than an unavailable private-labeled one.