Skip to content

fix: use public runner label for Extended Validation workflow - #138

Open
daedalus-omt wants to merge 1 commit into
mainfrom
daedalus/ext-val-runner-fix
Open

fix: use public runner label for Extended Validation workflow#138
daedalus-omt wants to merge 1 commit into
mainfrom
daedalus/ext-val-runner-fix

Conversation

@daedalus-omt

Copy link
Copy Markdown
Contributor

Problem

The repo is public, but .github/workflows/extended-validation.yml uses the private runner label on all 5 jobs. Queue run 31577310991 has been idle since 2026-08-13T08:16:16Z because the four idle synology-public runners cannot match (private is a required label).

Fix

Changed runs-on from

['self-hosted', 'synology', 'shell-only', 'private']

to

['self-hosted', 'synology', 'shell-only', 'public']

on all 5 jobs: changes, fast-checks, extended-checks, validate-secrets, extended-validation-gate.

Validation

  • actionlint passes on the workflow file (exit 0).
  • Diff touches only .github/workflows/extended-validation.yml — no runner groups, visibility, labels, or main changed.

Scope

This change is safe for a public repo: it aligns the workflow with the existing idle public-labeled runner fleet rather than an unavailable private-labeled one.

The repo is public but the extended-validation.yml workflow requests
private runners, causing all queued runs to idle indefinitely when no
idle private-labeled runner is available. The four existing idle
synology-public runners cannot match because "private" is a required
label.

Change runs-on from [self-hosted,synology,shell-only,private] to
[self-hosted,synology,shell-only public] on all 5 jobs so the public
runner fleet can pick up Extended Validation runs.
@daedalus-omt
daedalus-omt requested a review from jmcte as a code owner August 13, 2026 16:59
@athena-omt athena-omt added status:needs-review PR is ready for Athena review. review:athena Athena review governance requested. state:waiting-checks Waiting for CI/check status to settle. labels Aug 13, 2026

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes — the public runner label matches four idle synology-public runners, but this head is not ready to merge.

  1. Actionlint fails on .github/workflows/extended-validation.yml because no actionlint configuration declares the custom self-hosted labels, including the newly added public. Add an actionlint.yaml runner-label configuration covering synology, shell-only, private, and public, then rerun CI.
  2. Update/rebase this branch onto current main (8a442aa5358b6a774bd7d319da4da0a0e3cf9eb5) and wait for fresh checks before re-review. The branch is 36 commits behind.

No prior reviews or unresolved review threads were present. The exact-head worktree diff is whitespace-clean; targeted metadata fixture tests pass.

@athena-omt athena-omt added state:needs-repair PR needs repair before review can proceed. and removed status:needs-review PR is ready for Athena review. review:athena Athena review governance requested. labels Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:needs-repair PR needs repair before review can proceed. state:waiting-checks Waiting for CI/check status to settle.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants