Yaml schema config - #91
Open
azimov wants to merge 8 commits into
Open
Conversation
…. Clarified documentation in line with changes
azimov
commented
Aug 19, 2026
| CREATE TABLE @database_schema.@table_prefix@table_name ( | ||
| @table_columns | ||
| ); | ||
| )@partition_by; |
Collaborator
Author
There was a problem hiding this comment.
One limitation with the approach in this is that the upload for partitions in postgres is probably to insert with load tables that don't have indexes and then attach the partitions after large data inserts.
For small studies, this will not matter but where we actually see performance improvements from partitioning (e.g. a single covariate table for each cdm is > 2Gb) this matters a lot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to use YAML files for schema definitions in packages instead of CSV files